From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754306AbaCNLQ2 (ORCPT ); Fri, 14 Mar 2014 07:16:28 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:48997 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257AbaCNLQ1 (ORCPT ); Fri, 14 Mar 2014 07:16:27 -0400 Message-ID: <5322E4FC.7060605@ti.com> Date: Fri, 14 Mar 2014 13:16:12 +0200 From: Jyri Sarha User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Jean-Francois Moine , Mark Brown CC: , Xiubo Li , , Kuninori Morimoto Subject: Re: [alsa-devel] [PATCH v2 3/4] ASoC: simple-card: accept many DAI links References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2014 11:36 AM, Jean-Francois Moine wrote: > Some simple audio cards may have many DAI links. > This patch extends the simple-card driver for handling such cards. > > Signed-off-by: Jean-Francois Moine > --- [...] Why can't you just use two simple-card instances in your setup? You need to update the DT-binding document too when you are changing the binding. That way it would also be easier to follow what you are trying to accomplish here. The sysclk and tdm properties appear to only work in the dais of the first dai-link and __asoc_simple_card_dai_init() will not be called for other dais at all. The DT-binding of this implementation would look pretty hairy to me. Best regards, Jyri