From: David Ahern <dsahern@gmail.com>
To: Andi Kleen <ak@linux.intel.com>,
Venkatesh Srinivas <venkateshs@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
mingo@elte.hu, zheng.z.yan@intel.com
Subject: Re: [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU.
Date: Fri, 14 Mar 2014 10:57:58 -0600 [thread overview]
Message-ID: <53233516.10005@gmail.com> (raw)
In-Reply-To: <20140314161745.GH3793@tassilo.jf.intel.com>
On 3/14/14, 10:17 AM, Andi Kleen wrote:
>> The Intel ISR section for RDMSR seems to say: "Specifying a reserved
>> or unimplemented
>> MSR address in ECX will also cause a general protection exception".
>>
>> From a guest's perspective, MSR_RAPL_POWER_UNIT is unimplemented; kvm matches
>> this behavior.
>
> MSRs are model specific and defined per model number. If you report a model
> number you're expected to implement the MSRs defined for that model number.
>
> AFAIK Xen just reports 0 for unknown MSRs (and I'm surprised KVM doesn't too)
>
> I would suggest to fix KVM.
I believe ignore_msrs parameter to kvm handles that.
David
next prev parent reply other threads:[~2014-03-14 16:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 19:36 [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU Venkatesh Srinivas
2014-03-14 8:44 ` Peter Zijlstra
2014-03-14 13:56 ` Andi Kleen
2014-03-14 15:21 ` Venkatesh Srinivas
2014-03-14 16:17 ` Andi Kleen
2014-03-14 16:57 ` David Ahern [this message]
2014-03-14 23:07 ` Venkatesh Srinivas
2014-04-18 13:08 ` [tip:perf/core] perf/x86/intel: Use rdmsrl_safe() " tip-bot for Venkatesh Srinivas
2014-04-23 14:31 ` [PATCH] perf/x86/intel: Use rdmsrl_safe " Stephane Eranian
2014-04-23 14:45 ` Peter Zijlstra
2014-04-23 14:49 ` Stephane Eranian
2014-04-23 15:09 ` Peter Zijlstra
2014-04-23 15:14 ` Stephane Eranian
2014-04-23 15:16 ` Borislav Petkov
2014-04-23 15:18 ` Stephane Eranian
2014-04-23 15:35 ` Borislav Petkov
2014-04-23 15:44 ` Stephane Eranian
2014-04-23 15:55 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2014-03-07 4:42 Venkatesh Srinivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53233516.10005@gmail.com \
--to=dsahern@gmail.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=venkateshs@google.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox