linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Christie <mchristie@fusionio.com>
To: NeilBrown <neilb@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <linux-man@vger.kernel.org>
Subject: Re: SuSE O_DIRECT|O_NONBLOCK overload
Date: Fri, 14 Mar 2014 12:46:43 -0500	[thread overview]
Message-ID: <53234083.3060307@fusionio.com> (raw)
In-Reply-To: <20140313111555.2f15f19f@notabene.brown>

On 03/12/2014 07:15 PM, NeilBrown wrote:
> I also think there should probably be just one FAILFAST flag.  Where it was
> the DEV or the TRANSPORT or the DRIVER that failed could be returned in the
> error code for any caller that cared.  But as I don't know why the one became
> three I could well be missing something important.

It was for multipath. The problem was dm-multipath does not know what to
do with low level device errors, but wanted transport errors returned
quickly. Other drivers like the scsi_dh (formerly dm hardware handlers)
modules, want all errors fast failed.

I can add documentation or we can just change the code to better suite
your needs.

  reply	other threads:[~2014-03-14 17:55 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 13:26 [PATCH 0/1] block: rework flush sequencing for blk-mq Christoph Hellwig
2014-01-30 13:26 ` [PATCH 1/1] " Christoph Hellwig
2014-02-07  1:18   ` Shaohua Li
2014-02-07 14:19     ` Christoph Hellwig
2014-02-08  0:55       ` Shaohua Li
2014-02-10 10:33         ` Christoph Hellwig
2014-03-07 20:45   ` Jeff Moyer
2014-03-08 15:52     ` Christoph Hellwig
2014-03-08 17:33       ` Mike Snitzer
2014-03-08 19:51         ` Hannes Reinecke
2014-03-08 18:13           ` Mike Snitzer
2014-03-08 21:33             ` Hannes Reinecke
2014-03-08 22:09               ` [PATCH] block: fix q->flush_rq NULL pointer crash on dm-mpath flush Mike Snitzer
2014-03-09  0:24                 ` Jens Axboe
2014-03-09  0:57                   ` Mike Snitzer
2014-03-09  3:18                     ` Jens Axboe
2014-03-09  3:29                       ` Mike Snitzer
2014-03-12 10:28           ` [PATCH 1/1] block: rework flush sequencing for blk-mq Christoph Hellwig
2014-03-12 10:50             ` Hannes Reinecke
2014-03-12 10:55               ` Christoph Hellwig
2014-03-12 11:07                 ` Hannes Reinecke
2014-03-12 11:00               ` SuSE O_DIRECT|O_NONBLOCK overload Christoph Hellwig
2014-03-13  0:15                 ` NeilBrown
2014-03-14 17:46                   ` Mike Christie [this message]
2014-03-13 16:13             ` [PATCH 1/1] block: rework flush sequencing for blk-mq Mike Snitzer
2014-03-14  9:25               ` Christoph Hellwig
2014-03-14  9:30                 ` Hannes Reinecke
2014-03-14 12:44                   ` Christoph Hellwig
2014-03-14  9:34                 ` Christoph Hellwig
2014-03-14  9:52                   ` Hannes Reinecke
2014-03-14 10:58                     ` Christoph Hellwig
2014-03-14 11:10                       ` Hannes Reinecke
2014-03-14 13:00                 ` Mike Snitzer
2014-03-14 13:23                   ` Christoph Hellwig
2014-03-14 14:13                     ` Mike Snitzer
2014-03-15 13:28                       ` scsi_debug and mutipath, was " Christoph Hellwig
2014-03-17 11:55                       ` [dm-devel] " Bryn M. Reeves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53234083.3060307@fusionio.com \
    --to=mchristie@fusionio.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).