From: Tim Gardner <tim.gardner@canonical.com>
To: Hans de Goede <hdegoede@redhat.com>, Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
dann frazier <dann.frazier@canonical.com>
Subject: linux-next: ahci_platform broken build
Date: Sun, 16 Mar 2014 08:05:38 -0600 [thread overview]
Message-ID: <5325AFB2.4050505@canonical.com> (raw)
Gents - while reviewing some patches for arm64 in Ubuntu I noticed that
there is at least one patch sequence in linux-next that breaks the build.
156c5887948cd191417f18026aab9ce26e5a95da ahci-platform: Add support for
devices with more then 1 clock
039ece38da45f5e6a94be3aa7611cf3634bc2461 libahci: Allow drivers to
override start_engine
For example:
git reset --hard 156c5887948cd191417f18026aab9ce26e5a95da
echo "CONFIG_SATA_AHCI_PLATFORM=y" >> .config
make oldconfig scripts prepare
make M=drivers/ata
WARNING: Symbol version dump /home/rtg/linux/linux-next/Module.symvers
is missing; modules will have no dependencies and modversions.
CC drivers/ata/libata-core.o
CC drivers/ata/libata-scsi.o
CC drivers/ata/libata-eh.o
CC drivers/ata/libata-transport.o
CC drivers/ata/libata-sff.o
CC drivers/ata/libata-pmp.o
CC drivers/ata/libata-acpi.o
LD drivers/ata/libata.o
CC drivers/ata/ahci.o
CC drivers/ata/libahci.o
CC drivers/ata/ahci_platform.o
drivers/ata/ahci_platform.c: In function ‘ahci_probe’:
drivers/ata/ahci_platform.c:209:2: error: implicit declaration of
function ‘ahci_enable_clks’ [-Werror=implicit-function-declaration]
drivers/ata/ahci_platform.c:293:2: error: implicit declaration of
function ‘ahci_disable_clks’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[1]: *** [drivers/ata/ahci_platform.o] Error 1
make: *** [_module_drivers/ata] Error 2
The compile problem is then fixed in
96a01ba52c60fdd74dd6e8cf06645d06515b1396 (ahci-platform: Add enable_ /
disable_resources helper functions) which is not really kosher.
It seems like you ought to fix this before the 3.15 merge window opens.
rtg
--
Tim Gardner tim.gardner@canonical.com
next reply other threads:[~2014-03-16 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 14:05 Tim Gardner [this message]
2014-03-16 14:13 ` linux-next: ahci_platform broken build Hans de Goede
2014-03-16 14:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5325AFB2.4050505@canonical.com \
--to=tim.gardner@canonical.com \
--cc=dann.frazier@canonical.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox