From: Tomasz Figa <t.figa@samsung.com>
To: Cho KyongHo <pullip.cho@samsung.com>,
Sachin Kamat <sachin.kamat@linaro.org>
Cc: Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>,
Linux DeviceTree <devicetree@vger.kernel.org>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
Antonios Motakis <a.motakis@virtualopensystems.com>,
Grant Grundler <grundler@chromium.org>,
Joerg Roedel <joro@8bytes.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Prathyush <prathyush.k@samsung.com>,
Rahul Sharma <rahul.sharma@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Varun Sethi <Varun.Sethi@freescale.com>
Subject: Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions
Date: Tue, 18 Mar 2014 16:14:53 +0100 [thread overview]
Message-ID: <532862ED.8040809@samsung.com> (raw)
In-Reply-To: <20140318200915.7dd833ce0fddbbd6ecd8dac9@samsung.com>
On 18.03.2014 12:09, Cho KyongHo wrote:
> On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote:
>> Hi KyongHo,
>>
>> On 14 March 2014 10:35, Cho KyongHo <pullip.cho@samsung.com> wrote:
>>> This patch uses managed device helper functions in the probe().
>>>
>>> Signed-off-by: Cho KyongHo <pullip.cho@samsung.com>
>>> ---
>> [snip]
>>
>>> + data->clk = devm_clk_get(dev, "sysmmu");
>>> + if (IS_ERR(data->clk)) {
>>> + dev_info(dev, "No gate clock found!\n");
>>> + data->clk = NULL;
>>> + }
>>
>> Why aren't you returning from here upon error?
>
> It is for the case of a System MMU which does not need clock gating.
>
Are there really such cases?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-03-18 15:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 5:05 [PATCH v11 10/27] iommu/exynos: use managed device helper functions Cho KyongHo
2014-03-14 13:28 ` Tomasz Figa
2014-03-18 10:38 ` Cho KyongHo
2014-03-18 15:12 ` Tomasz Figa
2014-03-18 23:59 ` Jingoo Han
2014-03-19 8:56 ` Cho KyongHo
2014-03-14 15:22 ` Sachin Kamat
2014-03-18 11:09 ` Cho KyongHo
2014-03-18 15:14 ` Tomasz Figa [this message]
2014-03-19 8:59 ` Cho KyongHo
2014-03-19 9:01 ` Sachin Kamat
2014-03-19 12:08 ` Tomasz Figa
2014-03-20 10:03 ` Cho KyongHo
2014-03-20 10:44 ` Tomasz Figa
2014-03-21 4:49 ` Cho KyongHo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532862ED.8040809@samsung.com \
--to=t.figa@samsung.com \
--cc=Varun.Sethi@freescale.com \
--cc=a.motakis@virtualopensystems.com \
--cc=devicetree@vger.kernel.org \
--cc=grundler@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=prathyush.k@samsung.com \
--cc=pullip.cho@samsung.com \
--cc=rahul.sharma@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).