From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965446AbaCSPXU (ORCPT ); Wed, 19 Mar 2014 11:23:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:13348 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965001AbaCSPXT (ORCPT ); Wed, 19 Mar 2014 11:23:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,686,1389772800"; d="scan'208";a="503111997" Message-ID: <5329B525.2010603@intel.com> Date: Wed, 19 Mar 2014 17:17:57 +0200 From: Adrian Hunter User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Don Zickus CC: Jiri Olsa , Arnaldo Carvalho de Melo , Ingo Molnar , linux-kernel@vger.kernel.org, Stephane Eranian , Arnaldo Carvalho de Melo Subject: Re: [PATCH 06/13] perf tools: Use tid in mmap/mmap2 events to find maps References: <1395177965-8879-1-git-send-email-acme@infradead.org> <1395177965-8879-7-git-send-email-acme@infradead.org> <532943A2.7040407@intel.com> <20140319131945.GW25953@redhat.com> <20140319133025.GF1449@krava.brq.redhat.com> <5329A94D.9060701@intel.com> <20140319144353.GC25953@redhat.com> In-Reply-To: <20140319144353.GC25953@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/03/2014 4:43 p.m., Don Zickus wrote: > On Wed, Mar 19, 2014 at 04:27:25PM +0200, Adrian Hunter wrote: >> On 19.03.2014 15:30, Jiri Olsa wrote: >>> On Wed, Mar 19, 2014 at 09:19:45AM -0400, Don Zickus wrote: >>>> On Wed, Mar 19, 2014 at 09:13:38AM +0200, Adrian Hunter wrote: >>>>> On 18.03.2014 23:25, Arnaldo Carvalho de Melo wrote: >>>>>> From: Don Zickus >>>>>> >>>>>> Now that we can properly synthesize threads system-wide, make sure the >>>>>> mmap and mmap2 events use tids instead of pids to locate their maps. >>>>> >>>>> This is a good change but it cannot go yet because it is dependent on Jiri's >>>>> "perf tools: Share map groups within process" series. >>>> >>>> No it isn't. :-) Commit bfd66cc71a3f831ba7c2116d79416cfb8883f6cf is the >>>> reason why. It synthesizes thread events to make this work correctly. >>> >>> ok, I haven't realized this one was pulled in as well ;-) >>> it's ok then.. >> >> No, you mustn't split up the maps between threads. We currently assume >> CLONE_VM is always used to create threads. > > But that doesn't work when you try to synthesize threads which was the > problem I was trying to solve. It worked if you looked up the maps on the pid not the tid.