From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759635AbaCTRfJ (ORCPT ); Thu, 20 Mar 2014 13:35:09 -0400 Received: from mailout32.mail01.mtsvc.net ([216.70.64.70]:39549 "EHLO n23.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754731AbaCTRfE (ORCPT ); Thu, 20 Mar 2014 13:35:04 -0400 Message-ID: <532B26C1.8080806@hurleysoftware.com> Date: Thu, 20 Mar 2014 13:34:57 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: balbi@ti.com CC: Alan Cox , Marcel Holtmann , Greg KH , Muralidharan Karicheri , linux-bluetooth@vger.kernel.org, linux-serial@vger.kernel.org, Linux Kernel Mailing List , Huang Shijie Subject: Re: hci_ldsic nested locking problem References: <20140320163435.GH32692@saruman.home> <1395333736.22077.32.camel@acox1-desk.ger.corp.intel.com> <20140320171621.GA2827@saruman.home> <20140320172920.GC2827@saruman.home> In-Reply-To: <20140320172920.GC2827@saruman.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-User: 990527 peter@hurleysoftware.com X-MT-ID: 8FA290C2A27252AACF65DBC4A42F3CE3735FB2A4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ +cc Huang Shijie ] On 03/20/2014 01:29 PM, Felipe Balbi wrote: > then we need updates to Documentation: > > Documentation/serial/tty.txt:: > > | Driver Side Interfaces: > | > | receive_buf() - Hand buffers of bytes from the driver to the ldisc > | for processing. Semantics currently rather > | mysterious 8( > | > | write_wakeup() - May be called at any point between open and close. > | The TTY_DO_WRITE_WAKEUP flag indicates if a call > | is needed but always races versus calls. Thus the > | ldisc must be careful about setting order and to > | handle unexpected calls. Must not sleep. > | > | The driver is forbidden from calling this directly > | from the ->write call from the ldisc as the ldisc > | is permitted to call the driver write method from > | this function. In such a situation defer it. > > documentation says ldisc is allowed to call ->write() from > ->write_wakeup(). huh ? Patch submitted but never applied. http://www.spinics.net/lists/linux-serial/msg11144.html Regards, Peter Hurley