public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Warner Losh <imp@bsdimp.com>,
	Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>,
	David Woodhouse <dwmw2@infradead.org>, <galak@codeaurora.org>,
	<robh+dt@kernel.org>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<rob@landley.net>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	<grygorii.strashko@ti.com>, <devicetree@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mtd@lists.infradead.org>,
	Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option
Date: Thu, 20 Mar 2014 15:11:48 -0400	[thread overview]
Message-ID: <532B3D74.6070703@ti.com> (raw)
In-Reply-To: <20140320185452.GB21018@ld-irv-0074>

On Thursday 20 March 2014 02:54 PM, Brian Norris wrote:
> On Thu, Mar 20, 2014 at 02:02:39PM -0400, Santosh Shilimkar wrote:
>> On Thursday 20 March 2014 01:44 PM, Warner Losh wrote:
>>> I though sub page writing was one of the fields in the onfi and/or jedec(toggle) meta data structures. Have you looked there?
>>>
>> Am not sure if I follow you. The limitation is from the TI NAND controller(AEMIF) and
>> not the NAND memory. 
> 
> That doesn't match the patch description, which says "that flash doesn't
> support subpage writing". Flash != flash controller.
>
Patch description is indeed doesn't reflect the actual issue.

> Which one is it? If it's a controller limitation, I think we should be
> able to pull this from a "compatible" property, no?
> 
Just to be accurate, the limitation(bug) is on the controller found on Keystone
SOCs. AEMIF controller is also used on DaVinci SOCs which don't seems to have
any issue. So even for compatible, you need to add keystone specific one.
Hence thought dt property is better option.

regards,
Santosh


  reply	other threads:[~2014-03-20 19:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 17:06 [PATCH 0/3] Fix NAND propeties for k2hk-evm Ivan Khoronzhuk
2014-03-20 17:06 ` [PATCH 1/3] ARM: dts: k2hk-evm: set ubifs partition size for 512M NAND Ivan Khoronzhuk
2014-03-20 17:06 ` [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option Ivan Khoronzhuk
2014-03-20 17:12   ` Santosh Shilimkar
2014-03-20 17:29     ` Brian Norris
2014-03-20 17:37       ` Santosh Shilimkar
2014-03-20 17:44         ` Warner Losh
2014-03-20 18:02           ` Santosh Shilimkar
2014-03-20 18:09             ` Warner Losh
2014-03-20 18:54             ` Brian Norris
2014-03-20 19:11               ` Santosh Shilimkar [this message]
2014-03-20 19:26                 ` Ivan Khoronzhuk
2014-03-20 19:28                   ` Santosh Shilimkar
2014-03-20 18:42         ` Brian Norris
2014-03-20 17:06 ` [PATCH 3/3] ARM: dts: k2hk-evm: disable subpage write for davinci nand device Ivan Khoronzhuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532B3D74.6070703@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=galak@codeaurora.org \
    --cc=grygorii.strashko@ti.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=imp@bsdimp.com \
    --cc=ivan.khoronzhuk@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=m-karicheri2@ti.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob@landley.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox