From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Cédric Cabessa" <ced@ryick.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] coding style: fix line over 80 characters
Date: Fri, 21 Mar 2014 00:34:09 +0300 [thread overview]
Message-ID: <532B5ED1.8060406@cogentembedded.com> (raw)
In-Reply-To: <1395266697-8699-3-git-send-email-ced@ryick.net>
Hello.
On 03/20/2014 01:04 AM, Cédric Cabessa wrote:
> Signed-off-by: Cédric Cabessa <ced@ryick.net>
> ---
> drivers/staging/usbip/vhci_hcd.c | 33 ++++++++++++++++++++++-----------
> 1 file changed, 22 insertions(+), 11 deletions(-)
> diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
> index f690668..1e84577 100644
> --- a/drivers/staging/usbip/vhci_hcd.c
> +++ b/drivers/staging/usbip/vhci_hcd.c
> @@ -271,12 +271,14 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> }
> break;
> case USB_PORT_FEAT_POWER:
> - usbip_dbg_vhci_rh(" ClearPortFeature: USB_PORT_FEAT_POWER\n");
> + usbip_dbg_vhci_rh(
> + " ClearPortFeature: USB_PORT_FEAT_POWER\n");
Your version of scripts/checkpatch.pl seems outdated. It shouldn't
complain about strings violating 80-column limit (and I've just verified it
doesn't).
> @@ -539,7 +546,9 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
>
> default:
> /* NOT REACHED */
> - dev_err(dev, "invalid request to devnum 0 bRequest %u, wValue %u\n", ctrlreq->bRequest,
> + dev_err(dev,
> + "invalid request to devnum 0 bRequest %u, wValue %u\n",
> + ctrlreq->bRequest,
> ctrlreq->wValue);
> ret = -EINVAL;
> goto no_need_xmit;
> @@ -1060,7 +1069,9 @@ static int vhci_hcd_suspend(struct platform_device *pdev, pm_message_t state)
> spin_unlock(&the_controller->lock);
>
> if (connected > 0) {
> - dev_info(&pdev->dev, "We have %d active connection%s. Do not suspend.\n", connected, (connected == 1 ? "" : "s"));
> + dev_info(&pdev->dev,
> + "We have %d active connection%s. Do not suspend.\n",
> + connected, (connected == 1 ? "" : "s"));
> ret = -EBUSY;
> } else {
> dev_info(&pdev->dev, "suspend vhci_hcd");
Hm, I don't see checkpatch.pl complaints about these either in the
'usb-next' branch of Greg's tree.
WBR, Sergei
next prev parent reply other threads:[~2014-03-20 20:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 22:04 [PATCH 0/2] coding style for drivers/staging/usbip Cédric Cabessa
2014-03-19 22:04 ` [PATCH 1/2] coding style: fix quoted string split across lines Cédric Cabessa
2014-03-20 1:49 ` Greg Kroah-Hartman
2014-03-20 11:06 ` Joe Perches
2014-03-19 22:04 ` [PATCH 2/2] coding style: fix line over 80 characters Cédric Cabessa
2014-03-20 21:34 ` Sergei Shtylyov [this message]
2014-03-20 20:45 ` Joe Perches
2014-03-20 22:23 ` Sergei Shtylyov
2014-03-20 21:38 ` Sergei Shtylyov
2014-03-21 1:54 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B5ED1.8060406@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ced@ryick.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox