From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-kernel@vger.kernel.org, gleb@kernel.org,
mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP
Date: Thu, 20 Mar 2014 23:08:02 +0100 [thread overview]
Message-ID: <532B66C2.9020605@redhat.com> (raw)
In-Reply-To: <1395347087.632.38.camel@ul30vt.home>
Il 20/03/2014 21:24, Alex Williamson ha scritto:
>> >
>> > +void kvm_ioapic_inject_all(struct kvm_ioapic *ioapic, unsigned long irr)
>> > +{
> nit, kvm_ioapic_state.irr is a u32
Yes, but for_each_set_bit requires unsigned long.
>> > + u32 idx;
>> > +
>> > + rtc_irq_eoi_tracking_reset(ioapic);
>> > + for_each_set_bit(idx, &irr, 32) {
>
> Can we use IOAPIC_NUM_PINS in place of 32?
Yes, indeeed.
> > + printk("ioapic_service for GSI %d\n", idx);
>
> Is this leftover debugging? Maybe give it a loglevel if it's
> intentional. Looks reasonable otherwise. Thanks,
I'll remove it. Thanks for the review!
Paolo
next prev parent reply other threads:[~2014-03-20 22:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 14:54 [PATCH resend 0/4] KVM: cleanup ioapic and fix KVM_SET_IRQCHIP with irr != 0 Paolo Bonzini
2014-03-18 14:54 ` [PATCH 1/4] KVM: ioapic: merge ioapic_deliver into ioapic_service Paolo Bonzini
2014-03-20 20:25 ` Alex Williamson
2014-03-18 14:54 ` [PATCH 2/4] KVM: ioapic: clear IRR for edge-triggered interrupts at delivery Paolo Bonzini
2014-03-20 20:26 ` Alex Williamson
2014-03-18 14:54 ` [PATCH 3/4] KVM: ioapic: extract body of kvm_ioapic_set_irq Paolo Bonzini
2014-03-20 20:25 ` Alex Williamson
2014-03-20 22:09 ` Paolo Bonzini
2014-03-18 14:54 ` [PATCH 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP Paolo Bonzini
2014-03-18 15:10 ` Jan Kiszka
2014-03-18 15:21 ` Paolo Bonzini
2014-03-20 20:24 ` Alex Williamson
2014-03-20 22:08 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-18 14:27 [PATCH 0/4] KVM: cleanup ioapic and fix KVM_SET_IRQCHIP with irr != 0 Paolo Bonzini
2014-03-18 14:27 ` [PATCH 4/4] KVM: ioapic: reinject pending interrupts on KVM_SET_IRQCHIP Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B66C2.9020605@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).