From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760648AbaCUKef (ORCPT ); Fri, 21 Mar 2014 06:34:35 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:35552 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759943AbaCUKee (ORCPT ); Fri, 21 Mar 2014 06:34:34 -0400 Message-ID: <532C23BF.4040208@cogentembedded.com> Date: Fri, 21 Mar 2014 14:34:23 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Zheng Li , netdev@vger.kernel.org, fubar@us.ibm.com, andy@greyhouse.net CC: linux-kernel@vger.kernel.org, davem@davemloft.net, joe.jin@oracle.com Subject: Re: [PATCH] bonding: Inactive slaves should keep inactive flag's value to 1. References: <1395305504-29973-1-git-send-email-zheng.x.li@oracle.com> In-Reply-To: <1395305504-29973-1-git-send-email-zheng.x.li@oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 03/20/2014 11:51 AM, Zheng Li wrote: > Except bond mode 1, in other bond modes, inactive slaves should keep inactive flag to > 1 to refuse to receive broadcast packets. Now, active slave send broadcast packets > (for example ARP requests) which will arrive inactive slaves on same host from switch, > but inactive slave's inactive flag is zero that cause bridge receive the broadcast > packets to produce a wrong entry in forward table. Typical situation is domu send some > ARP request which go out from dom0 bond's active slave, then the ARP broadcast request > packets go back to inactive slave from switch, because the inactive slave's inactive > flag is zero, kernel will receive the packets and pass them to bridge, that cause dom0's > bridge map domu's MAC address to port of bond, bridge should map domu's MAC to port of vif. > Signed-off-by: Zheng Li > --- > drivers/net/bonding/bond_main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index e5628fc..2f73f18 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -3063,7 +3063,7 @@ static int bond_open(struct net_device *bond_dev) > bond_set_slave_inactive_flags(slave, > BOND_SLAVE_NOTIFY_NOW); > } else { > - bond_set_slave_active_flags(slave, > + bond_set_slave_state(slave, BOND_STATE_ACTIVE, > BOND_SLAVE_NOTIFY_NOW); Now you have to re-indent this line to start right under 'state'. WBR, Sergei