From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [PATCH] lkdtm: include cacheflush.h
Date: Fri, 21 Mar 2014 15:36:16 -0400 [thread overview]
Message-ID: <532C94B0.9090602@windriver.com> (raw)
In-Reply-To: <CAGXu5jKZwxPbhE1a0MfjQBRe0Dzxip0iiR2Rp4JFn38YRQFk_Q@mail.gmail.com>
On 14-03-21 03:33 PM, Kees Cook wrote:
> On Fri, Mar 21, 2014 at 12:31 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>> On Fri, Feb 14, 2014 at 6:58 PM, Kees Cook <keescook@chromium.org> wrote:
>>> Some architectures need cacheflush.h explicitly included (mips) for
>>> use of flush_icache_range():
>>>
>>> config: make ARCH=mips allmodconfig
>>> All error/warnings:
>>> >> ERROR: "flush_icache_range" undefined!
>>
>> The linux-next builds still fail with a similar error:
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/10808358/
>>
>> I'm not sure if it ever was a compile error, or if it was always
>> a missing export symbol type error as it is apparently now.
>
> It seems no one picked up this fix? Greg, you normally take my lkdtm work...
No, the "fix" is there, in linux-next, but it doesn't work. :)
Paul.
--
>
> -Kees
>
>>
>> Paul.
>> --
>>
>>>
>>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>> ---
>>> drivers/misc/lkdtm.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
>>> index 47ed2d321351..2ebd52e05773 100644
>>> --- a/drivers/misc/lkdtm.c
>>> +++ b/drivers/misc/lkdtm.c
>>> @@ -46,6 +46,7 @@
>>> #include <linux/debugfs.h>
>>> #include <linux/vmalloc.h>
>>> #include <linux/mman.h>
>>> +#include <asm/cacheflush.h>
>>>
>>> #ifdef CONFIG_IDE
>>> #include <linux/ide.h>
>>> --
>>> 1.7.9.5
>>>
>>>
>>> --
>>> Kees Cook
>>> Chrome OS Security
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
next prev parent reply other threads:[~2014-03-21 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 23:58 [PATCH] lkdtm: include cacheflush.h Kees Cook
2014-03-21 18:31 ` Paul Gortmaker
2014-03-21 19:33 ` Kees Cook
2014-03-21 19:36 ` Paul Gortmaker [this message]
2014-03-22 15:32 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C94B0.9090602@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=arnd@arndb.de \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox