Re: [PATCHv4 0/5] devfreq: exynos: Fix minor issue and code clean to remove legacy method

[Tomasz Figa <tomasz.figa@gmail.com>]

Hi,

[fixing mistyped addresses of me and Bartlomiej]

On 20.03.2014 03:59, Chanwoo Choi wrote:
> This patchset use SIMPLE_DEV_PM_OPS macro intead of legacy method and fix
> probe fail if CONFIG_PM_OPP is disabled. Also, this patchset fix minor issue.
>
> Changes from v3:
> - Discard patches related to DT support because DT support patch of patchset
>    don't satisfy the basic of dt concept. So, I'm going to implement DT support
>    patch regardless this patchset separately.
> - Use SIMPLE_DEV_PM_OPS macro instead of SET_SYSTEM_SLEEP_PM_OPS macro
> - Delete devfreq->profile->exit callback to improve readability when failure
>    happen in probe().
> - Add exynos5 patch to clean code
>
> Changes from v2:
> - Add detailed description to Documentation/devicetree/bindings/exynos4_bus.txt
>    and change patch description of patch#8
> - Change the sequence of patchset in patch #1 ~ #4
> - Fix minor issue
>
> Changes from v1:
> - Add exynos4_bus.txt documentation for devicetree guide
> - Fix probe failure if CONFIG_PM_OPP is disabled
> - Fix typo and resource leak(regulator/clock/memory) when happening probe failure
> - Add additionally comment for PPMU usage instead of previous PPC
> - Split separate patch to remove ambiguous of patch
>
> Chanwoo Choi (5):
>    devfreq: exynos4: Fix bug of resource leak and code clean on probe()
>    devfreq: exynos4: Use SIMPLE_DEV_PM_OPS macro
>    devfreq: exynos4: Add CONFIG_PM_OPP dependency to fix probe fail
>    devfreq: exynos5: Use SIMPLE_DEV_PM_OPS macro
>    devfreq: exynos5: Add CONFIG_PM_OPP dependency to fix probe fail
>
>   drivers/devfreq/Kconfig              |  2 ++
>   drivers/devfreq/exynos/exynos4_bus.c | 43 ++++++++++++++++++++++--------------
>   drivers/devfreq/exynos/exynos5_bus.c |  7 ++++--
>   3 files changed, 34 insertions(+), 18 deletions(-)
>

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz