[PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using

[PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using

[Chen Gang]

Need export symbol flush_icache_range() to modules, just like another
platforms have done, or can not pass compiling.

The related error (with allmodconfig under avr32):

  ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
  make[1]: *** [__modpost] Error 1
  make: *** [modules] Error 2


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/avr32/mm/cache.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/avr32/mm/cache.c b/arch/avr32/mm/cache.c
index 6a46ecd..85d635c 100644
--- a/arch/avr32/mm/cache.c
+++ b/arch/avr32/mm/cache.c
@@ -111,6 +111,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
 	__flush_icache_range(start & ~(linesz - 1),
 			     (end + linesz - 1) & ~(linesz - 1));
 }
+EXPORT_SYMBOL(flush_icache_range);
 
 /*
  * This one is called from __do_fault() and do_swap_page().
-- 
1.7.11.7

Re: [PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using

[Chen Gang]

After this patch, our linux kernel can pass "avr32-linux-" allmodconfig
(it contents quite a few of warnings, but after check, I guess they are
not kernel's issue).

:-)

Thanks.


On 03/09/2014 05:35 AM, Chen Gang wrote:
> Need export symbol flush_icache_range() to modules, just like another
> platforms have done, or can not pass compiling.
> 
> The related error (with allmodconfig under avr32):
> 
>   ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
>   make[1]: *** [__modpost] Error 1
>   make: *** [modules] Error 2
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/avr32/mm/cache.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/avr32/mm/cache.c b/arch/avr32/mm/cache.c
> index 6a46ecd..85d635c 100644
> --- a/arch/avr32/mm/cache.c
> +++ b/arch/avr32/mm/cache.c
> @@ -111,6 +111,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
>  	__flush_icache_range(start & ~(linesz - 1),
>  			     (end + linesz - 1) & ~(linesz - 1));
>  }
> +EXPORT_SYMBOL(flush_icache_range);
>  
>  /*
>   * This one is called from __do_fault() and do_swap_page().
> 


-- 
Chen Gang

Open, share and attitude like air, water and life which God blessed

Re: [PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using

[Hans-Christian Egtvedt]

Around Sun 09 Mar 2014 05:47:04 +0800 or thereabout, Chen Gang wrote:
> 
> After this patch, our linux kernel can pass "avr32-linux-" allmodconfig
> (it contents quite a few of warnings, but after check, I guess they are
> not kernel's issue).

That sounds great, I am a bit surprised however that the lkdtm module need
flush_icache_range. Would have been interesting to look into what causes this
dependency.

I will pull this into my for-linus branch, and push during the next merge
window.

> On 03/09/2014 05:35 AM, Chen Gang wrote:
>> Need export symbol flush_icache_range() to modules, just like another
>> platforms have done, or can not pass compiling.
>> 
>> The related error (with allmodconfig under avr32):
>> 
>>   ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
>>   make[1]: *** [__modpost] Error 1
>>   make: *** [modules] Error 2
>> 
>> 
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

>> ---
>>  arch/avr32/mm/cache.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/avr32/mm/cache.c b/arch/avr32/mm/cache.c
>> index 6a46ecd..85d635c 100644
>> --- a/arch/avr32/mm/cache.c
>> +++ b/arch/avr32/mm/cache.c
>> @@ -111,6 +111,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
>>  	__flush_icache_range(start & ~(linesz - 1),
>>  			     (end + linesz - 1) & ~(linesz - 1));
>>  }
>> +EXPORT_SYMBOL(flush_icache_range);
>>  
>>  /*
>>   * This one is called from __do_fault() and do_swap_page().
-- 
mvh
Hans-Christian Egtvedt

Re: [PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using

[Chen Gang]

On 03/09/2014 06:17 AM, Hans-Christian Egtvedt wrote:
> Around Sun 09 Mar 2014 05:47:04 +0800 or thereabout, Chen Gang wrote:
>>
>> After this patch, our linux kernel can pass "avr32-linux-" allmodconfig
>> (it contents quite a few of warnings, but after check, I guess they are
>> not kernel's issue).
> 
> That sounds great, I am a bit surprised however that the lkdtm module need
> flush_icache_range. Would have been interesting to look into what causes this
> dependency.
> 

"driver/misc/lkdtm.c" will use this flush_icache_range().

And some architectures export it to modules.

  [root@gchen arch]# grep -rn flush_icache_range * | grep EXPORT
  arm64/mm/flush.c:105:EXPORT_SYMBOL(flush_icache_range);
  avr32/mm/cache.c:114:EXPORT_SYMBOL(flush_icache_range);
  m68k/mm/cache.c:106:EXPORT_SYMBOL(flush_icache_range);
  mn10300/mm/cache-inv-icache.c:129:EXPORT_SYMBOL(flush_icache_range);
  mn10300/mm/cache-flush-icache.c:155:EXPORT_SYMBOL(flush_icache_range);
  sparc/mm/init_64.c:435:EXPORT_SYMBOL(flush_icache_range);


Welcome any more details information by any other members, thanks.


> I will pull this into my for-linus branch, and push during the next merge
> window.
> 

OK, thanks

>> On 03/09/2014 05:35 AM, Chen Gang wrote:
>>> Need export symbol flush_icache_range() to modules, just like another
>>> platforms have done, or can not pass compiling.
>>>
>>> The related error (with allmodconfig under avr32):
>>>
>>>   ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
>>>   make[1]: *** [__modpost] Error 1
>>>   make: *** [modules] Error 2
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> 
> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> 

OK, thanks.

>>> ---
>>>  arch/avr32/mm/cache.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/avr32/mm/cache.c b/arch/avr32/mm/cache.c
>>> index 6a46ecd..85d635c 100644
>>> --- a/arch/avr32/mm/cache.c
>>> +++ b/arch/avr32/mm/cache.c
>>> @@ -111,6 +111,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
>>>  	__flush_icache_range(start & ~(linesz - 1),
>>>  			     (end + linesz - 1) & ~(linesz - 1));
>>>  }
>>> +EXPORT_SYMBOL(flush_icache_range);
>>>  
>>>  /*
>>>   * This one is called from __do_fault() and do_swap_page().


-- 
Chen Gang

Open, share and attitude like air, water and life which God blessed

Re: [PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using

[Chen Gang]

On 03/09/2014 11:19 PM, Chen Gang wrote:
> On 03/09/2014 06:17 AM, Hans-Christian Egtvedt wrote:
>> Around Sun 09 Mar 2014 05:47:04 +0800 or thereabout, Chen Gang wrote:
>>>
>>> After this patch, our linux kernel can pass "avr32-linux-" allmodconfig
>>> (it contents quite a few of warnings, but after check, I guess they are
>>> not kernel's issue).
>>
>> That sounds great, I am a bit surprised however that the lkdtm module need
>> flush_icache_range. Would have been interesting to look into what causes this
>> dependency.
>>

After read a little more details for lkdtm, I guess "after overwrite an
executable area by do_nothing(), it needs flush_icache_range() to be
sure the new instructions/data must have effect with all cpu".

Welcome any additional information for it.

Thanks.

> 
> "driver/misc/lkdtm.c" will use this flush_icache_range().
> 
> And some architectures export it to modules.
> 
>   [root@gchen arch]# grep -rn flush_icache_range * | grep EXPORT
>   arm64/mm/flush.c:105:EXPORT_SYMBOL(flush_icache_range);
>   avr32/mm/cache.c:114:EXPORT_SYMBOL(flush_icache_range);
>   m68k/mm/cache.c:106:EXPORT_SYMBOL(flush_icache_range);
>   mn10300/mm/cache-inv-icache.c:129:EXPORT_SYMBOL(flush_icache_range);
>   mn10300/mm/cache-flush-icache.c:155:EXPORT_SYMBOL(flush_icache_range);
>   sparc/mm/init_64.c:435:EXPORT_SYMBOL(flush_icache_range);
> 
> 
> Welcome any more details information by any other members, thanks.
> 
> 

Thanks.
-- 
Chen Gang

Open, share and attitude like air, water and life which God blessed

Re: [PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using

[Chen Gang]

Is this patch OK?

If it is necessary to continue analysing more details, please let me
know, and I will/should continue.

Thanks.

On 03/16/2014 05:18 AM, Chen Gang wrote:
> On 03/09/2014 11:19 PM, Chen Gang wrote:
>> On 03/09/2014 06:17 AM, Hans-Christian Egtvedt wrote:
>>> Around Sun 09 Mar 2014 05:47:04 +0800 or thereabout, Chen Gang wrote:
>>>>
>>>> After this patch, our linux kernel can pass "avr32-linux-" allmodconfig
>>>> (it contents quite a few of warnings, but after check, I guess they are
>>>> not kernel's issue).
>>>
>>> That sounds great, I am a bit surprised however that the lkdtm module need
>>> flush_icache_range. Would have been interesting to look into what causes this
>>> dependency.
>>>
> 
> After read a little more details for lkdtm, I guess "after overwrite an
> executable area by do_nothing(), it needs flush_icache_range() to be
> sure the new instructions/data must have effect with all cpu".
> 
> Welcome any additional information for it.
> 
> Thanks.
> 
>>
>> "driver/misc/lkdtm.c" will use this flush_icache_range().
>>
>> And some architectures export it to modules.
>>
>>   [root@gchen arch]# grep -rn flush_icache_range * | grep EXPORT
>>   arm64/mm/flush.c:105:EXPORT_SYMBOL(flush_icache_range);
>>   avr32/mm/cache.c:114:EXPORT_SYMBOL(flush_icache_range);
>>   m68k/mm/cache.c:106:EXPORT_SYMBOL(flush_icache_range);
>>   mn10300/mm/cache-inv-icache.c:129:EXPORT_SYMBOL(flush_icache_range);
>>   mn10300/mm/cache-flush-icache.c:155:EXPORT_SYMBOL(flush_icache_range);
>>   sparc/mm/init_64.c:435:EXPORT_SYMBOL(flush_icache_range);
>>
>>
>> Welcome any more details information by any other members, thanks.
>>
>>
> 
> Thanks.
> 


-- 
Chen Gang

Open, share and attitude like air, water and life which God blessed

Re: [PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using

[Hans-Christian Egtvedt]

Around Sun 23 Mar 2014 07:12:46 +0800 or thereabout, Chen Gang wrote:
> Is this patch OK?
> 

I reread everything you said, and it looks sane.

> If it is necessary to continue analysing more details, please let me
> know, and I will/should continue.

No, I will append it to my for-linus branch, and submit it early in the next
cycle. It should be just around the corner, Linus just released rc8 (-:

> On 03/16/2014 05:18 AM, Chen Gang wrote:
>> On 03/09/2014 11:19 PM, Chen Gang wrote:
>>> On 03/09/2014 06:17 AM, Hans-Christian Egtvedt wrote:
>>>> Around Sun 09 Mar 2014 05:47:04 +0800 or thereabout, Chen Gang wrote:
>>>>>
>>>>> After this patch, our linux kernel can pass "avr32-linux-" allmodconfig
>>>>> (it contents quite a few of warnings, but after check, I guess they are
>>>>> not kernel's issue).
>>>>
>>>> That sounds great, I am a bit surprised however that the lkdtm module need
>>>> flush_icache_range. Would have been interesting to look into what causes this
>>>> dependency.
>>>>
>> 
>> After read a little more details for lkdtm, I guess "after overwrite an
>> executable area by do_nothing(), it needs flush_icache_range() to be
>> sure the new instructions/data must have effect with all cpu".
>> 
>> Welcome any additional information for it.
>> 
>> Thanks.
>> 
>>>
>>> "driver/misc/lkdtm.c" will use this flush_icache_range().
>>>
>>> And some architectures export it to modules.
>>>
>>>   [root@gchen arch]# grep -rn flush_icache_range * | grep EXPORT
>>>   arm64/mm/flush.c:105:EXPORT_SYMBOL(flush_icache_range);
>>>   avr32/mm/cache.c:114:EXPORT_SYMBOL(flush_icache_range);
>>>   m68k/mm/cache.c:106:EXPORT_SYMBOL(flush_icache_range);
>>>   mn10300/mm/cache-inv-icache.c:129:EXPORT_SYMBOL(flush_icache_range);
>>>   mn10300/mm/cache-flush-icache.c:155:EXPORT_SYMBOL(flush_icache_range);
>>>   sparc/mm/init_64.c:435:EXPORT_SYMBOL(flush_icache_range);
>>>
>>> Welcome any more details information by any other members, thanks.
>> 
>> Thanks.
-- 
mvh
Hans-Christian Egtvedt

Re: [PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using

[Chen Gang]

On 03/25/2014 04:48 PM, Hans-Christian Egtvedt wrote:
> Around Sun 23 Mar 2014 07:12:46 +0800 or thereabout, Chen Gang wrote:
>> Is this patch OK?
>>
> 
> I reread everything you said, and it looks sane.
> 
>> If it is necessary to continue analysing more details, please let me
>> know, and I will/should continue.
> 
> No, I will append it to my for-linus branch, and submit it early in the next
> cycle. It should be just around the corner, Linus just released rc8 (-:
> 

Thank you very much.


-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed