From: Guenter Roeck <linux@roeck-us.net>
To: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>,
Jean Delvare <jdelvare@suse.de>
Cc: David Dajun Chen <david.chen@diasemi.com>,
LINUX-DOC <linux-doc@vger.kernel.org>,
LINUX-KERNEL <linux-kernel@vger.kernel.org>,
LM-SENSORS <lm-sensors@lm-sensors.org>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Landley <rob@landley.net>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [RFC V1 1/3] hwmon: da9063: HWMON driver
Date: Sun, 23 Mar 2014 20:27:24 -0700 [thread overview]
Message-ID: <532FA61C.7070601@roeck-us.net> (raw)
In-Reply-To: <420d4f5c8436a66b511693531cfeda131258ce69.1395607051.git.stwiss.opensource@diasemi.com>
On 03/23/2014 01:37 PM, Opensource [Steve Twiss] wrote:
> From: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
>
> Add the HWMON driver for DA9063
>
> Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
> ---
> +
> + ret = sysfs_create_group(&pdev->dev.kobj, &da9063_attr_group);
> + if (ret)
> + return ret;
> +
> + hwmon->classdev = hwmon_device_register(&pdev->dev);
> + if (IS_ERR(hwmon->classdev)) {
> + sysfs_remove_group(&pdev->dev.kobj, &da9063_attr_group);
> + return PTR_ERR(hwmon->classdev);
> + }
> +
Hi Steve,
This looks like an ideal candidate for devm_hwmon_device_register_with_groups().
Can you use that API, please ?
Thanks,
Guenter
next prev parent reply other threads:[~2014-03-24 3:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-23 20:37 [RFC V1 0/3] da9063: Addition of HWMON support for DA9063 Opensource [Steve Twiss]
2014-03-23 20:37 ` [RFC V1 1/3] hwmon: da9063: HWMON driver Opensource [Steve Twiss]
2014-03-24 3:27 ` Guenter Roeck [this message]
2014-03-24 3:39 ` Guenter Roeck
2014-03-24 7:48 ` Opensource [Steve Twiss]
2014-03-24 9:24 ` Lee Jones
2014-03-24 7:52 ` Lee Jones
2014-03-24 8:12 ` Opensource [Steve Twiss]
2014-03-23 20:37 ` [RFC V1 2/3] mfd: da9063: Add HWMON dependencies Opensource [Steve Twiss]
2014-03-24 8:02 ` Lee Jones
2014-03-24 8:28 ` Opensource [Steve Twiss]
2014-03-23 20:37 ` [RFC V1 3/3] Documentation: hwmon: New information for DA9063 Opensource [Steve Twiss]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532FA61C.7070601@roeck-us.net \
--to=linux@roeck-us.net \
--cc=broonie@linaro.org \
--cc=david.chen@diasemi.com \
--cc=jdelvare@suse.de \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=p.zabel@pengutronix.de \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox