From: Jens Axboe <axboe@kernel.dk>
To: Monam Agarwal <monamagarwal123@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Use RCU_INIT_POINTER(x, NULL) in blk-ioc.c
Date: Mon, 24 Mar 2014 12:58:21 -0700 [thread overview]
Message-ID: <53308E5D.1050800@kernel.dk> (raw)
In-Reply-To: <1395520154-2815-1-git-send-email-monamagarwal123@gmail.com>
On 2014-03-22 13:29, Monam Agarwal wrote:
> This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
>
> The rcu_assign_pointer() ensures that the initialization of a structure
> is carried out before storing a pointer to that structure.
> And in the case of the NULL pointer, there is no structure to initialize.
> So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
What's the point of further complicating the API for cases where we
don't even really care about performance?
--
Jens Axboe
prev parent reply other threads:[~2014-03-24 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 20:29 [PATCH] block: Use RCU_INIT_POINTER(x, NULL) in blk-ioc.c Monam Agarwal
2014-03-24 19:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53308E5D.1050800@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).