From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Shuah Khan <shuah.kh@samsung.com>,
gregkh@linuxfoundation.org, john@jjdev.com, ced@ryick.net
Cc: linux-usb@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, shuahkhan@gmail.com
Subject: Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check
Date: Tue, 25 Mar 2014 19:38:17 +0300 [thread overview]
Message-ID: <5331B0F9.9000403@cogentembedded.com> (raw)
In-Reply-To: <1395702729-3281-1-git-send-email-shuah.kh@samsung.com>
Hello.
On 03/25/2014 02:12 AM, Shuah Khan wrote:
> Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7
Please also specify that commit's summary line in parens. Also, there's
now an established format for such things:
Fixes: <12-digit SHA ID> ("<summary line>")
You can place such line before your signoff line.
> This commit added return value check for sscanf() that parses the
> input buffer for four input items. However, the return value check
> is incorrect, as it checks for one input item instead of four which
> is what it is expecting in the input buffer. As a result, sscanf()
> will always fail even when the input buffer is correct.
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
WBR, Sergei
prev parent reply other threads:[~2014-03-25 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 23:12 [PATCH] staging/usbip: fix store_attach() sscanf return value check Shuah Khan
2014-03-25 0:38 ` Greg KH
2014-03-25 2:34 ` Shuah Khan
2014-03-25 16:38 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5331B0F9.9000403@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ced@ryick.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john@jjdev.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox