From: micky <micky_ching@realsil.com.cn>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chris Ball <chris@printf.net>,
Samuel Ortiz <sameo@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
<devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Roger <rogerable@realtek.com>, Wei WANG <wei_wang@realsil.com.cn>
Subject: Re: [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify errorhandle
Date: Wed, 26 Mar 2014 09:29:37 +0800 [thread overview]
Message-ID: <53322D81.3050701@realsil.com.cn> (raw)
In-Reply-To: <CAPDyKFrk-7msEVcYzY5Vc+ZODtMbiCWGAMU7G2oscgN1Ad9URA@mail.gmail.com>
Hi Ulf,
On 03/25/2014 06:44 PM, Ulf Hansson wrote:
> On 25 March 2014 10:47, <micky_ching@realsil.com.cn> wrote:
>> From: Micky Ching <micky_ching@realsil.com.cn>
>>
>> Add new command type(R1 without CRC) handle, without this
>> patch mmc card initialize will be failed.
>>
>> Using a more careful handle in request timeout, this would
>> improve error recover capability. Debug info is printed
>> using non DMA mode, this would help print more accurately
>> for DMA command failed. Smatch warning was removed.
> Hi Micky,
>
> Seems like this patchset has been around for some time, sorry for the delay.
>
> I don't have any objections to it getting merged, but you need to run
> checkpatch of your patches. Patch2 has a warning you should fix.
Patch2 is based on <mmc: rtsx: fix bug and support nonblocking request>
see: https://lkml.org/lkml/2014/2/17/270
checkpatch.pl seems ok, is there any thing I need to check?
Best Regards.
micky.
> Kind regards
> Ulf Hansson
>
>
>> Micky Ching (2):
>> mmc: rtsx: add R1-no-CRC mmc command type handle
>> mmc: rtsx: modify error handle and remove smatch warnings
>>
>> drivers/mmc/host/rtsx_pci_sdmmc.c | 121 ++++++++++++++++++++-----------------
>> 1 file changed, 67 insertions(+), 54 deletions(-)
>>
>> --
>> 1.7.9.5
> .
>
next prev parent reply other threads:[~2014-03-26 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 9:47 [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify error handle micky_ching
2014-03-25 9:47 ` [PATCH 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle micky_ching
2014-03-25 9:47 ` [PATCH 2/2] mmc: rtsx: modify error handle and remove smatch warnings micky_ching
2014-03-25 10:44 ` [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify error handle Ulf Hansson
2014-03-26 1:29 ` micky [this message]
2014-03-26 8:34 ` [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify errorhandle Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53322D81.3050701@realsil.com.cn \
--to=micky_ching@realsil.com.cn \
--cc=chris@printf.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox