From: David Ahern <dsahern@gmail.com>
To: Josef Bacik <jbacik@fb.com>,
linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
mingo@redhat.com, acme@ghostprotocols.net
Subject: Re: [PATCH] perf: make perf script actually spit out backtraces for events
Date: Wed, 26 Mar 2014 13:27:36 -0600 [thread overview]
Message-ID: <53332A28.70306@gmail.com> (raw)
In-Reply-To: <1395860245-12418-1-git-send-email-jbacik@fb.com>
On 3/26/14, 12:57 PM, Josef Bacik wrote:
> We are trying to debug a problem internally and noticed that if we use perf
> record -g -e <tracepoint> and then try to use perf script to get the events and
> their backtraces that we weren't getting the backtraces, even though they were
> collected and would show up with perf report. For some reason the tracepoint
> print stuff didn't have the right things set in order to print out backtraces.
> I have no idea why this is as adding them in there makes the backtraces come out
> properly, and if we don't use the -g option perf script still acts properly with
> those options set. Hopefully this is the correct fix, it has fixed the problem
> for us. Thanks,
You can manually request fields using the -f option.
That said ...
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> ---
> NOTE: I looked at MAINTAINERS to see if there was a perf list and it didn't look
> like there was one, sorry if this is the wrong place to send patches to.
>
> tools/perf/builtin-script.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index baf1798..6d14c06 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -99,7 +99,9 @@ static struct {
>
> .fields = PERF_OUTPUT_COMM | PERF_OUTPUT_TID |
> PERF_OUTPUT_CPU | PERF_OUTPUT_TIME |
> - PERF_OUTPUT_EVNAME | PERF_OUTPUT_TRACE,
> + PERF_OUTPUT_EVNAME | PERF_OUTPUT_TRACE |
> + PERF_OUTPUT_IP | PERF_OUTPUT_SYM |
> + PERF_OUTPUT_DSO,
A change has been applied to upstream:
https://lkml.org/lkml/2013/11/30/63
David
next prev parent reply other threads:[~2014-03-26 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 18:57 [PATCH] perf: make perf script actually spit out backtraces for events Josef Bacik
2014-03-26 19:27 ` David Ahern [this message]
2014-03-26 19:33 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53332A28.70306@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=jbacik@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).