From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756742AbaC0Rng (ORCPT ); Thu, 27 Mar 2014 13:43:36 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:43041 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753351AbaC0Rnd (ORCPT ); Thu, 27 Mar 2014 13:43:33 -0400 Message-ID: <5334633E.6050708@atmel.com> Date: Thu, 27 Mar 2014 18:43:26 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Alexandre Belloni , , Hans-Christian Egtvedt , Bryan Wu , Thierry Reding , Jingoo Han CC: , Jean-Christophe Plagniol-Villard , Haavard Skinnemoen , "Richard Purdie" , Greg Kroah-Hartman , , , Subject: Re: [PATCH 00/16] move at91 and avr32 to the PWM framework, remove obsolete drivers References: <1395234209-15546-1-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1395234209-15546-1-git-send-email-alexandre.belloni@free-electrons.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/03/2014 14:03, Alexandre Belloni : > Hi, > > This patch set swtiches the at91 and avr32 SoCs and board to the generic PWM > framework. This allows to remove the obsolete leds-atmel-pwm, atmel-pwm-bl and > atmel_pwm drivers. > > The first 6 patches take care of the AT91 boards and removes a useless function > in the process. > > Patch 7 makes pwm-ateml buildable for AVR32 > > Patch 8 allows setting the pwm polarity for pwm_bl when using platform data. > This is required afterwards for the favr-32 > > Patches 9-13 take care of the AVR32 boards. This has only been compile tested as > I don't own any of those boards. > > And the last 3 patches are removing the now obsolete drivers. > > As a note, the atmel_pwm driver has two features not yet available through > pwm-atmel: > - it is possible to pass an IRQ handler that will get called each time one of > the channel period has been acheived. > - it was possible to set clka and clkb, two clock that divided mck before > feeding the pwm controller. > > Those features are not used by anything in the mainline. I'm not sure we can > implement the first one. We'll get back the second one once all the boards have > swtiched to the common clock framework. > > > Alexandre Belloni (16): > ARM: at91: at91sam9g45: switch to generic PWM framework > ARM: at91: sam9m10g45ek: use generic leds_pwm driver > ARM: at91: at91sam9263: switch to generic PWM framework > ARM: at91: sam9263ek: use generic leds_pwm driver > ARM: at91: at91sam9rl: switch to generic PWM framework > ARM: at91: remove useless at91_pwm_leds() > PWM: atmel: allow building for AVR32 > backlight: pwm_bl: set pwm polarity when using platform data > avr32/at32ap: switch to the generic PWM framework > avr32: MRMT: use generic leds_pwm driver > avr32: merisc: use generic leds_pwm driver > avr32: favr-32: use generic pwm_bl driver > avr32: update defconfig to use the generic PWM framework > backlight: atmel-pwm-bl: remove obsolete driver > leds: atmel-pwm: remove obsolete driver > misc: atmel_pwm: remove obsolete driver I am fine with the whole series. For the AT91 specific bits, you can add my: Acked-by: Nicolas Ferre It is a very nice cleanup and I can take the series with me in the AT91 git tree (likely the at91-3.16-cleanup or at91-3.16-drivers branch) if everybody agree. Bye, > arch/arm/mach-at91/at91sam9263.c | 1 + > arch/arm/mach-at91/at91sam9263_devices.c | 11 +- > arch/arm/mach-at91/at91sam9g45.c | 1 + > arch/arm/mach-at91/at91sam9g45_devices.c | 11 +- > arch/arm/mach-at91/at91sam9rl.c | 1 + > arch/arm/mach-at91/at91sam9rl_devices.c | 11 +- > arch/arm/mach-at91/board-sam9263ek.c | 56 +++- > arch/arm/mach-at91/board-sam9m10g45ek.c | 43 ++- > arch/arm/mach-at91/board.h | 1 - > arch/arm/mach-at91/leds.c | 37 --- > arch/avr32/boards/atngw100/mrmt.c | 35 ++- > arch/avr32/boards/favr-32/setup.c | 49 ++-- > arch/avr32/boards/merisc/setup.c | 34 ++- > arch/avr32/configs/atngw100_mrmt_defconfig | 5 +- > arch/avr32/configs/atstk1002_defconfig | 5 +- > arch/avr32/configs/atstk1003_defconfig | 5 +- > arch/avr32/configs/atstk1004_defconfig | 5 +- > arch/avr32/configs/atstk1006_defconfig | 5 +- > arch/avr32/configs/favr-32_defconfig | 6 +- > arch/avr32/configs/merisc_defconfig | 5 +- > arch/avr32/mach-at32ap/at32ap700x.c | 7 +- > drivers/leds/Kconfig | 8 - > drivers/leds/Makefile | 1 - > drivers/leds/leds-atmel-pwm.c | 149 ----------- > drivers/misc/Kconfig | 9 - > drivers/misc/Makefile | 1 - > drivers/misc/atmel_pwm.c | 402 ----------------------------- > drivers/pwm/Kconfig | 2 +- > drivers/video/backlight/Kconfig | 11 - > drivers/video/backlight/Makefile | 1 - > drivers/video/backlight/atmel-pwm-bl.c | 223 ---------------- > drivers/video/backlight/pwm_bl.c | 8 + > include/linux/atmel-pwm-bl.h | 43 --- > include/linux/atmel_pwm.h | 70 ----- > include/linux/pwm_backlight.h | 1 + > 35 files changed, 199 insertions(+), 1064 deletions(-) > delete mode 100644 drivers/leds/leds-atmel-pwm.c > delete mode 100644 drivers/misc/atmel_pwm.c > delete mode 100644 drivers/video/backlight/atmel-pwm-bl.c > delete mode 100644 include/linux/atmel-pwm-bl.h > delete mode 100644 include/linux/atmel_pwm.h > -- Nicolas Ferre