* [PATCH] Fix coding style issue in xlr_net.c
@ 2014-03-28 9:43 Neil Armstrong
2014-03-28 10:45 ` Dan Carpenter
2014-03-28 10:47 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Neil Armstrong @ 2014-03-28 9:43 UTC (permalink / raw)
To: devel; +Cc: linux-kernel, Greg Kroah-Hartman, David S. Miller, Archana kumari
checkpatch script returns the following warning:
WARNING: line over 80 characters
310: FILE: drivers/staging/netlogic/xlr_net.c:310:
+ void *accel_priv, select_queue_fallback_t fallback)
This patch fixes the coding style issue.
Signed-off-by: Neil Armstrong <superna9999@gmail.com>
---
drivers/staging/netlogic/xlr_net.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/netlogic/xlr_net.c
b/drivers/staging/netlogic/xlr_net.c
index 31b269a..cef0b8a 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -307,7 +307,8 @@ static netdev_tx_t xlr_net_start_xmit(struct sk_buff
*skb,
}
static u16 xlr_net_select_queue(struct net_device *ndev, struct sk_buff
*skb,
- void *accel_priv, select_queue_fallback_t fallback)
+ struct sk_buff *skb, void *accel_priv,
+ select_queue_fallback_t fallback)
{
return (u16)smp_processor_id();
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix coding style issue in xlr_net.c
2014-03-28 9:43 [PATCH] Fix coding style issue in xlr_net.c Neil Armstrong
@ 2014-03-28 10:45 ` Dan Carpenter
2014-03-28 10:47 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-03-28 10:45 UTC (permalink / raw)
To: Neil Armstrong
Cc: devel, Greg Kroah-Hartman, Archana kumari, linux-kernel,
David S. Miller
On Fri, Mar 28, 2014 at 10:43:43AM +0100, Neil Armstrong wrote:
> checkpatch script returns the following warning:
> WARNING: line over 80 characters
> 310: FILE: drivers/staging/netlogic/xlr_net.c:310:
> + void *accel_priv, select_queue_fallback_t fallback)
>
> This patch fixes the coding style issue.
>
> Signed-off-by: Neil Armstrong <superna9999@gmail.com>
Patch is corrupted by mail client read Documentation/email-clients.txt
or `use git send-email`.
Also the patch looks wrong. Did you try compiling it?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix coding style issue in xlr_net.c
2014-03-28 9:43 [PATCH] Fix coding style issue in xlr_net.c Neil Armstrong
2014-03-28 10:45 ` Dan Carpenter
@ 2014-03-28 10:47 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-03-28 10:47 UTC (permalink / raw)
To: Neil Armstrong
Cc: devel, Greg Kroah-Hartman, Archana kumari, linux-kernel,
David S. Miller
The subject should be:
[PATCH] Staging: netlogic: long lines in xlr_net.c
You were missing the subsystem prefix: "Staging: netlogic:".
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-28 10:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-28 9:43 [PATCH] Fix coding style issue in xlr_net.c Neil Armstrong
2014-03-28 10:45 ` Dan Carpenter
2014-03-28 10:47 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox