From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbaC1Pad (ORCPT ); Fri, 28 Mar 2014 11:30:33 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:17096 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495AbaC1Pa2 (ORCPT ); Fri, 28 Mar 2014 11:30:28 -0400 X-AuditID: cbfec7f4-b7f796d000005a13-99-53359591436b Message-id: <5335958B.80107@samsung.com> Date: Fri, 28 Mar 2014 16:30:19 +0100 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Sakari Ailus Cc: linux-media@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, s.nawrocki@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com, Bryan Wu , Richard Purdie Subject: Re: [PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs References: <1395327070-20215-1-git-send-email-j.anaszewski@samsung.com> <1395327070-20215-2-git-send-email-j.anaszewski@samsung.com> <20140323231833.GA2054@valkosipuli.retiisi.org.uk> In-reply-to: <20140323231833.GA2054@valkosipuli.retiisi.org.uk> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t/xy7oTp5oGG9yYzmtxa905VoujOycy Wcw/AmSdbXrDbnF51xw2i61v1jFa9GzYymqxe9dTVovDb9pZLc7sX8nmwOWxc9Zddo/DXxey eOyZ/4PVo2/LKkaPz5vkAlijuGxSUnMyy1KL9O0SuDKuHGtiLXghWLFv+zG2BsalfF2MnBwS AiYSc/feZoawxSQu3FvP1sXIwSEksJRRojUHJCwk8JlR4nVHCUiYV0BDYvLnfJAwi4CqxJW7 31hBbDYBQ4mfL14zgdiiAhESf07vA4vzCghK/Jh8jwXEFhFQk3i66SGYzSzQxiTRtcwbxBYW CJXom78XqJcLaNUeRondZ96DDeIUsJf4vvgoE0SDtcTKSdsYIWx5ic1r3jJPYBSYhWTHLCRl s5CULWBkXsUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kREv5fdjAuPmZ1iFGAg1GJhzej3TRY iDWxrLgy9xCjBAezkghv1kSgEG9KYmVValF+fFFpTmrxIUYmDk6pBsbkhjVnAjqZ75+fPU3o 54Udd0W0thyuCkjpPPdboWzWNuNVv7uu18deex17IX3Bw8e3hUr1rK3X7J00b2vReoHqHf+m +er1VHQI6HyZ9IpNZMGsGbfsbnLOfvfwTO3DDq8YZVZT5/PSMzfdLQ5n7Wo5Mefl/Z2fknee LlxcZxO4eQFj0cqfcSurlViKMxINtZiLihMBFMycb10CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sakari, Thanks for the review. On 03/24/2014 12:18 AM, Sakari Ailus wrote: > Hi Jacek, > > Thanks for the patchset. It's very nice in general. I have a few comments > below. [...] >> diff --git a/include/linux/leds.h b/include/linux/leds.h >> index 0287ab2..1bf0ab3 100644 >> --- a/include/linux/leds.h >> +++ b/include/linux/leds.h >> @@ -17,6 +17,14 @@ >> #include >> #include >> #include >> +#include > > mutex.h should be earlier in the list of included files. > >> +#include >> + >> +#define LED_FAULT_OVER_VOLTAGE (1 << 0) >> +#define LED_FAULT_TIMEOUT (1 << 1) >> +#define LED_FAULT_OVER_TEMPERATURE (1 << 2) >> +#define LED_FAULT_SHORT_CIRCUIT (1 << 3) >> +#define LED_FAULT_OVER_CURRENT (1 << 4) > > This patch went in to the media-tree some time ago. I wonder if the relevant > bits should be added here now as well. > > commit 935aa6b2e8a911e81baecec0537dd7e478dc8c91 > Author: Daniel Jeong > Date: Mon Mar 3 06:52:08 2014 -0300 > > [media] v4l2-controls.h: Add addtional Flash fault bits > > Three Flash fault are added. V4L2_FLASH_FAULT_UNDER_VOLTAGE for the case low > voltage below the min. limit. V4L2_FLASH_FAULT_INPUT_VOLTAGE for the case > falling input voltage and chip adjust flash current not occur under voltage > event. V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE for the case the temperature > exceed the maximun limit > > Signed-off-by: Daniel Jeong > Signed-off-by: Sakari Ailus > Signed-off-by: Mauro Carvalho Chehab As it will not cause a build break and any runtime problems, even if the patch is not merged, I added these bits to my implementation. BTW I have doubts about V4L2_FLASH_FAULT_INDICATOR and V4L2_CID_FLASH_INDICATOR_INTENSITY control. I did not take them into account in my implementation because it is not clear for me how an indicator led is related to a torch led. There is a control for setting indicator intensity but there is not one for enabling it. Could you shed some light on this issue? Regards, Jacek Anaszewski