From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385AbaC1RJF (ORCPT ); Fri, 28 Mar 2014 13:09:05 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:37209 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752226AbaC1RJA (ORCPT ); Fri, 28 Mar 2014 13:09:00 -0400 Message-ID: <5335BABE.80007@cogentembedded.com> Date: Fri, 28 Mar 2014 21:09:02 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: "qiang.zhao@freescale.com" , "linuxppc-dev@lists.ozlabs.org" , "netdev@vger.kernel.org" , Scott Wood CC: "linux-kernel@vger.kernel.org" , "davem@davemloft.net" , "mugunthanvnm@ti.com" , "zonque@gmail.com" , "helmut.schaa@googlemail.com" , Xiaobo Xie Subject: Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode References: <1395901116-16034-1-git-send-email-B45475@freescale.com> <53341101.9000404@cogentembedded.com> <0ca1e7910cd247c4aebe4cbd48a633cb@BLUPR03MB341.namprd03.prod.outlook.com> In-Reply-To: <0ca1e7910cd247c4aebe4cbd48a633cb@BLUPR03MB341.namprd03.prod.outlook.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 03/28/2014 10:36 AM, qiang.zhao@freescale.com wrote: >>> The at8031 can work on polling mode and interrupt mode. >>> Add ack_interrupt and config intr funcs to enable interrupt mode for >>> it. >>> Signed-off-by: Zhao Qiang >>> --- >>> drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index >>> bc71947..d034ef5 100644 >>> --- a/drivers/net/phy/at803x.c >>> +++ b/drivers/net/phy/at803x.c >> [...] >>> @@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device >> *phydev) >>> return 0; >>> } >>> >>> +static int at803x_ack_interrupt(struct phy_device *phydev) { >>> + int err; >>> + >>> + err = phy_read(phydev, AT803X_INSR); >> Could make this an initializer... > Thank you very much. However I have no idea about "make this an initializer". int err = phy_read(phydev, AT803X_INSR); WBR, Sergei