From: Michal Marek <mmarek@suse.cz>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] kbuild: unconditionally clobber include/linux/version.h on distclean
Date: Sat, 29 Mar 2014 21:00:47 +0100 [thread overview]
Message-ID: <5337266F.4030407@suse.cz> (raw)
In-Reply-To: <1392326938-14405-1-git-send-email-paul.gortmaker@windriver.com>
Dne 13.2.2014 22:28, Paul Gortmaker napsal(a):
> As of v3.7, the UAPI changes relocated headers around such that the
> kernel version header lived in a new place.
>
> If a person is bisecting and if you go back to pre-UAPI days,
> you will create an include/linux/version.h -- then if you checkout a
> post-UAPI kernel, and even run "make distclean" it still won't delete
> that old version file. So you get a situation like this:
>
> $ grep -R LINUX_VERSION_CODE include/
> include/generated/uapi/linux/version.h:#define LINUX_VERSION_CODE 200192
> include/linux/version.h:#define LINUX_VERSION_CODE 132646
>
> The value in that second line is representative of a v2.6.38 version.
> And it will be sourced/used, hence leading to strange behaviours, such
> as drivers/staging content (which typically hasn't been purged of version
> ifdefs) failing to build.
>
> Since it is a subtle mode of failure, lets always clobber the old
> file when doing a distclean.
>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied to kbuild.git, sorry for the delay. I'm curious how long will it
take until somebody posts a cleanup patch removing the obsolete
include/linux/version.h reference...
Michal
prev parent reply other threads:[~2014-03-29 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 21:28 [PATCH] kbuild: unconditionally clobber include/linux/version.h on distclean Paul Gortmaker
2014-02-15 22:54 ` David Howells
2014-03-29 20:00 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5337266F.4030407@suse.cz \
--to=mmarek@suse.cz \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox