Re: [PATCH V2] scripts: objdiff: detect object code changes between two commits

[Michal Marek <mmarek@suse.cz>]

Dne 24.3.2014 03:14, Jason Cooper napsal(a):
> 
> objdiff can be used in conjunction with a git rebase to confirm that
> each commit made no changes to the resulting object code.  It has the
> same return values as diff(1).

This looks nice. Just a few comments below:


> +# usage example:
> +#
> +# $ git checkout COMMIT_A
> +# $ <your fancy build command here>
> +# $ ./scripts/objdiff record path/to/*.o
> +#
> +# $ git checkout COMMIT_B
> +# $ <your fancy build command here>
> +# $ ./scripts/objdiff record path/to/*.o
> +#
> +# $ ./scripts/objdiff diff COMMIT_A COMMIT_B
> +# $
> +
> +# And to clean up (everything is in /tmp/objdiff-*)
> +# $ ./scripts/objdiff clean all

Can you change it to use some path in the source tree, like .tmp_objdiff
or so? Then you can have make distclean remove it and you can avoid the
fixed paths in /tmp.


> +		# force rebuild
> +		rm -f "$f"

Is this working around some kbuild bug, or is it more a "just in case?"
One usually assumes that "record" is a readonly operation and can be
repeated.

Thanks,
Michal