public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Demers <alexandre.f.demers@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [Regression, bisected 9e30cc] "sysfs, kernfs: no need to kern_mount() sysfs from sysfs_init()" prevents system from booting correctly
Date: Sat, 29 Mar 2014 18:08:30 -0400	[thread overview]
Message-ID: <5337445E.3080903@gmail.com> (raw)
In-Reply-To: <20140329181258.GF5553@htj.dyndns.org>

That fixes the problem, I'm now running 3.14-rc8 with your patch 
applied.

Alexandre Demers

On Sat 29 Mar 2014 02:12:58 PM EDT, Tejun Heo wrote:
> Hello, Alexander.
>
> On Thu, Mar 27, 2014 at 01:47:53PM -0400, Alexandre Demers wrote:
>> I'll do my best, but I just don't have enough time right now for
>> everything I have to do at home and dig this bug. I may be able to
>> look at it in the next couple of days though, or it may go somewhere
>> next week... That being said, I tried yesterday to have a better idea
>> and I thank you for the "ScrLck" trick, I didn't know that it was
>> working. Nevertheless I didn't find anything.
>>
>> It seems as if the transition from the temporary kernel's fs to the
>> hard disk's fs is not done correctly. If I boot with a working kernel
>> after that, I can't find any trace of where it was trying to copy the
>> files or of any partition being full. Could it be filling the RAM
>> until it reaches its maximum capacity (16GB to fill before hitting the
>> limit and throwing the errors)? That would explain at least why it
>> takes so much time before the flood of errors begins...
>
> That could definitely be the case.  I'd really like to get to the
> bottom of it.  It's really curious that there aren't more people
> reporting the same problem.  Can you please try whether the following
> patch makes the regression go away?
>
> Thanks!
>
> diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c
> index a66ad61..a3223e2 100644
> --- a/fs/sysfs/mount.c
> +++ b/fs/sysfs/mount.c
> @@ -75,5 +75,7 @@ int __init sysfs_init(void)
>   		return err;
>   	}
>
> +	WARN_ON(IS_ERR(kern_mount(&sysfs_fs_type)));
> +
>   	return 0;
>   }

  reply	other threads:[~2014-03-29 22:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 13:27 [Regression, bisected 9e30cc] "sysfs, kernfs: no need to kern_mount() sysfs from sysfs_init()" prevents system from booting correctly Alexandre Demers
2014-03-14 14:08 ` Tejun Heo
2014-03-14 15:48   ` Alexandre Demers
2014-03-17 20:13     ` Tejun Heo
2014-03-18  2:08       ` Alexandre Demers
2014-03-26  1:03         ` Alexandre Demers
2014-03-26 13:18           ` Tejun Heo
2014-03-27 17:47             ` Alexandre Demers
2014-03-29 18:12               ` Tejun Heo
2014-03-29 22:08                 ` Alexandre Demers [this message]
2014-03-30 12:31                   ` Tejun Heo
2014-03-30 16:53                     ` Alexandre Demers
2014-04-02  5:42                       ` Alexandre Demers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5337445E.3080903@gmail.com \
    --to=alexandre.f.demers@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox