From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758892AbdENO7a (ORCPT ); Sun, 14 May 2017 10:59:30 -0400 Received: from gloria.sntech.de ([95.129.55.99]:41242 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbdENO73 (ORCPT ); Sun, 14 May 2017 10:59:29 -0400 From: Heiko Stuebner To: Randy Li Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: rockchip: add missing grf phandle for rk3288 Date: Sun, 14 May 2017 16:59:17 +0200 Message-ID: <53387334.ADQf94xZqP@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <20170507143446.11502-1-ayaka@soulik.info> References: <20170507143446.11502-1-ayaka@soulik.info> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, Am Sonntag, 7. Mai 2017, 22:34:46 CEST schrieb Randy Li: > The PWM devices need to access the grf to switch the PWM IP. The grf property is not part of the pwm binding and I remember this coming up in veyron times, when Thiery didn't want such settings in the pwm driver. So the kernel pwm driver does not switch anything right now. > And tsadc uses it to shutdown the system. No it doesn't. The tsadc on rk3288 does not do any grf settings right now, as it is using the v2_initialize function. Only rk3366 and rk3399 seem to do any grf settings in the current v4.12-rc1 . Or is there some tsadc patch from you pending to change that? Heiko