From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbaCaGor (ORCPT ); Mon, 31 Mar 2014 02:44:47 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:33931 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbaCaGop (ORCPT ); Mon, 31 Mar 2014 02:44:45 -0400 Message-ID: <53391212.70205@oracle.com> Date: Mon, 31 Mar 2014 14:58:26 +0800 From: "zheng.li" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: fubar@us.ibm.com CC: Zheng Li , netdev@vger.kernel.org, andy@greyhouse.net, linux-kernel@vger.kernel.org, davem@davemloft.net, joe.jin@oracle.com Subject: Re: [PATCH] bonding: Inactive slaves should keep inactive flag's value to 1 References: <1395998529-5937-1-git-send-email-zheng.x.li@oracle.com> In-Reply-To: <1395998529-5937-1-git-send-email-zheng.x.li@oracle.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jay, What's you think about the new patch. Thanks, Zheng Li 于 2014年03月28日 17:22, Zheng Li 写道: > In bond mode tlb and alb, inactive slaves should keep inactive flag to 1 to > refuse to receive broadcast packets. Now, active slave send broadcast packets > (for example ARP requests) which will arrive inactive slaves on same host from > switch, but inactive slave's inactive flag is zero that cause bridge receive the > broadcast packets to produce a wrong entry in forward table. Typical situation > is domu send some ARP request which go out from dom0 bond's active slave, then > the ARP broadcast request packets go back to inactive slave from switch, because > the inactive slave's inactive flag is zero, kernel will receive the packets and > pass them to bridge that cause dom0's bridge map domu's MAC address to port of > bond, bridge should map domu's MAC to port of vif. > > Signed-off-by: Zheng Li > --- > drivers/net/bonding/bond_main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index e5628fc..f97d72e 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -3058,7 +3058,7 @@ static int bond_open(struct net_device *bond_dev) > if (bond_has_slaves(bond)) { > read_lock(&bond->curr_slave_lock); > bond_for_each_slave(bond, slave, iter) { > - if ((bond->params.mode == BOND_MODE_ACTIVEBACKUP) > + if ((bond->params.mode == BOND_MODE_ACTIVEBACKUP || bond_is_lb(bond)) > && (slave != bond->curr_active_slave)) { > bond_set_slave_inactive_flags(slave, > BOND_SLAVE_NOTIFY_NOW); >