From: Laura Abbott <lauraa@codeaurora.org>
To: Kees Cook <keescook@chromium.org>,
"Jon Medhurst (Tixy)" <tixy@linaro.org>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
"Larry Bassel" <lbassel@codeaurora.org>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Russell King" <linux@arm.linux.org.uk>,
"Nicolas Pitre" <nico@linaro.org>,
"Ben Dooks" <ben.dooks@codethink.co.uk>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Grant Likely" <grant.likely@linaro.org>,
"Dave Martin" <Dave.Martin@arm.com>,
"Jiang Liu" <liuj97@gmail.com>,
"Christoffer Dall" <cdall@cs.columbia.edu>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Rob Herring" <rob.herring@calxeda.com>,
"Vitaly Andrianov" <vitalya@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Simon Baatz" <gmbnomis@gmail.com>,
"Jonathan Austin" <jonathan.austin@arm.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] ARM: mm: keep rodata non-executable
Date: Tue, 01 Apr 2014 15:54:42 -0700 [thread overview]
Message-ID: <533B43B2.1020805@codeaurora.org> (raw)
In-Reply-To: <CAGXu5jLEA5u58yNe0k4BobWphAhEiREJ1ped30LVgDRPzOGy7A@mail.gmail.com>
On 4/1/2014 3:34 PM, Kees Cook wrote:
> On Mon, Mar 24, 2014 at 3:47 AM, Jon Medhurst (Tixy) <tixy@linaro.org> wrote:
>> On Sun, 2014-03-23 at 16:21 -0600, Kees Cook wrote:
>>> For this stage, how about I make this "depends on KEXEC=n &&
>>> KPROBES=n"?
>>
>> There's also ftrace (CONFIG_DYNAMIC_FTRACE I believe) which modifies
>> kernel code with a call to probe_kernel_write(), which GDB uses as well.
>>
>> And grepping for the patch_text() function also shows
>> __arch_jump_label_transform() modifies kernel code. Not sure how and
>> when that gets used.
>
> Right, so, I'm trying to fix ftrace now, and I've hit a wall. It is as
> if changes to the kernel text PMD aren't being noticed after the
> kernel is running. Does anyone know why this might be happening?
>
> Code and details here:
> https://lkml.org/lkml/2014/4/1/674
>
> -Kees
>
We had a flush_tlb_kernel_page after the pmd_flush in our out of tree code
which makes the text writeable in __patch_text.
Laura
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-04-01 22:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 1:04 [PATCH 0/2] ARM: mm: allow for stricter kernel memory perms Kees Cook
2014-02-14 1:04 ` [PATCH 1/2] " Kees Cook
2014-02-14 1:04 ` [PATCH 2/2] ARM: mm: keep rodata non-executable Kees Cook
2014-02-14 16:22 ` Dave Martin
2014-02-14 19:11 ` Kees Cook
2014-02-17 12:34 ` Dave Martin
2014-02-18 18:10 ` Kees Cook
2014-02-21 12:37 ` Dave Martin
2014-02-21 13:20 ` Russell King - ARM Linux
2014-02-21 22:09 ` Kees Cook
2014-03-13 19:07 ` Kees Cook
2014-03-23 18:32 ` Laura Abbott
2014-03-23 22:20 ` Kees Cook
2014-03-23 18:47 ` Laura Abbott
2014-03-23 22:21 ` Kees Cook
2014-03-23 22:37 ` Nicolas Pitre
2014-03-23 22:56 ` Kees Cook
2014-03-24 10:47 ` Jon Medhurst (Tixy)
2014-04-01 22:34 ` Kees Cook
2014-04-01 22:54 ` Laura Abbott [this message]
2014-04-01 22:59 ` Kees Cook
2014-03-24 12:30 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533B43B2.1020805@codeaurora.org \
--to=lauraa@codeaurora.org \
--cc=Dave.Martin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ben.dooks@codethink.co.uk \
--cc=catalin.marinas@arm.com \
--cc=cdall@cs.columbia.edu \
--cc=gmbnomis@gmail.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathan.austin@arm.com \
--cc=keescook@chromium.org \
--cc=lbassel@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=liuj97@gmail.com \
--cc=marc.zyngier@arm.com \
--cc=nico@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=santosh.shilimkar@ti.com \
--cc=sfr@canb.auug.org.au \
--cc=tixy@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vitalya@ti.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox