From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932200AbaDBOJG (ORCPT ); Wed, 2 Apr 2014 10:09:06 -0400 Received: from mail.active-venture.com ([67.228.131.205]:55824 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932178AbaDBOJC (ORCPT ); Wed, 2 Apr 2014 10:09:02 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <533C19FB.8090302@roeck-us.net> Date: Wed, 02 Apr 2014 07:08:59 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Julia Lawall , Wim Van Sebroeck CC: kernel-janitors@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync References: <1396360159-16244-1-git-send-email-Julia.Lawall@lip6.fr> <1396360159-16244-4-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1396360159-16244-4-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/01/2014 06:49 AM, Julia Lawall wrote: > From: Julia Lawall > > Use del_timer_sync to ensure that the timer is stopped on all CPUs before > the driver exits. > > This change was suggested by Thomas Gleixner. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @r@ > identifier i,t,ex; > @@ > struct t i = { .remove = ex, }; > > @@ > identifier r.ex; > @@ > ex(...) { > <... > - del_timer > + del_timer_sync > (...) > ...> > } > // > > Signed-off-by: Julia Lawall > Reviewed-by: Guenter Roeck