The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joel Pelaez Jorge <joelpelaez@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Silvan Jegen <s.jegen@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] Staging: rtl8192e: Fix sparse warning
Date: Sun, 06 Apr 2014 13:43:38 -0500	[thread overview]
Message-ID: <5341A05A.5080403@gmail.com> (raw)

Fix a sparse warning, non static symbol is no declared as such.
And fix a conflict with static function declared extern to include
rtl_wx.h header.

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
symbol 'r8192_wx_handlers_def' was not declared. Should it be static?

Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com>
---
  drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c 
b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index 498995d..f17584d 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -19,6 +19,7 @@

  #include <linux/string.h>
  #include "rtl_core.h"
+#include "rtl_wx.h"

  #define RATE_COUNT 12
  static u32 rtl8192_rates[] = {
@@ -1293,7 +1294,7 @@ static iw_handler r8192_private_handler[] = {
  	(iw_handler)r8192_wx_get_PromiscuousMode,
  };

-static struct iw_statistics *r8192_get_wireless_stats(struct net_device 
*dev)
+struct iw_statistics *r8192_get_wireless_stats(struct net_device *dev)
  {
  	struct r8192_priv *priv = rtllib_priv(dev);
  	struct rtllib_device *ieee = priv->rtllib;
-- 
1.7.10.4


             reply	other threads:[~2014-04-06 18:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-06 18:43 Joel Pelaez Jorge [this message]
2014-04-06 18:49 ` [PATCH v2] Staging: rtl8192e: Fix sparse warning Joe Perches
2014-04-06 19:00   ` Joel Pelaez Jorge
2014-04-06 19:02     ` Joe Perches
2014-04-06 19:01 ` Greg Kroah-Hartman
2014-04-06 19:12   ` Joel Pelaez Jorge
2014-04-06 20:26     ` Greg Kroah-Hartman
2014-04-06 20:43       ` Joel Pelaez Jorge
2014-04-06 20:59         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5341A05A.5080403@gmail.com \
    --to=joelpelaez@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.jegen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox