From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756158AbaDHBBQ (ORCPT ); Mon, 7 Apr 2014 21:01:16 -0400 Received: from mail-pb0-f53.google.com ([209.85.160.53]:61668 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754671AbaDHBBM (ORCPT ); Mon, 7 Apr 2014 21:01:12 -0400 Message-ID: <53434A4E.2050407@gmail.com> Date: Tue, 08 Apr 2014 09:01:02 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Viresh Kumar CC: Guan Xuetao , "Rafael J. Wysocki" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , stable@vger.kernel.org Subject: Re: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' References: <53429445.5000005@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2014 08:08 PM, Viresh Kumar wrote: > On 7 April 2014 17:34, Chen Gang wrote: >> Need use 'clk' instead of 'mclk', which is the original removed local >> variable. >> >> The related original commit: >> >> "652ed95 cpufreq: introduce cpufreq_generic_get() routine" >> >> The related error with allmodconfig for unicore32: >> >> CC drivers/cpufreq/unicore2-cpufreq.o >> drivers/cpufreq/unicore2-cpufreq.c: In function 'ucv2_target': >> drivers/cpufreq/unicore2-cpufreq.c:48: error: 'struct cpufreq_policy' has no member named 'mclk' >> make[2]: *** [drivers/cpufreq/unicore2-cpufreq.o] Error 1 >> make[1]: *** [drivers/cpufreq] Error 2 >> make: *** [drivers] Error 2 >> >> >> Signed-off-by: Chen Gang >> --- >> drivers/cpufreq/unicore2-cpufreq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Stupid mistake. > It is very easy to lead other members to make mistakes, or let ourself make mistakes. > Acked-by: Viresh Kumar > > @stable: please apply this for v3.14, as it broke in that cycle.. > Thank you. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed