From: Aaron Lu <aaron.lu@intel.com>
To: Stephen Chandler Paul <thatslyude@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Shawn Rutledge <shawn.t.rutledge@gmail.com>
Subject: Re: [PATCH] Favor native backlight interface for ThinkPad Helix
Date: Tue, 08 Apr 2014 10:49:17 +0800 [thread overview]
Message-ID: <534363AD.9070401@intel.com> (raw)
In-Reply-To: <1396622686-6373-1-git-send-email-thatslyude@gmail.com>
On 04/04/2014 10:44 PM, Stephen Chandler Paul wrote:
> Like many other Windows 8 laptops the ThinkPad Helix's backlight has a
> broken ACPI interface and can only be properly adjusted by using the
> video card's native backlight control. This adds the ThinkPad Helix to
> the list of laptops affected with this issue so that
> video.use_native_backlight is enabled by default.
It would be good to attach your acpidump so that we know for sure and if
one day we need to remove this entry, we can verify its table.
Bug 51231 is tracking this problem and mostly are thinkpad laptops, so
please attach your acpidump and dmi there, thanks.
https://bugzilla.kernel.org/show_bug.cgi?id=51231
-Aaron
>
> Signed-off-by: Stephen Chandler Paul <thatslyude@gmail.com>
> ---
> drivers/acpi/video.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 48c7e8a..8b6990e 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -488,6 +488,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
> },
> },
> {
> + .callback = video_set_use_native_backlight,
> + .ident = "Thinkpad Helix",
> + .matches = {
> + DMI_MATCH(DMI_SYS_Vhttps://bugzilla.kernel.org/show_bug.cgi?id=51231ENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Helix"),
> + },
> + },
> + {
> .callback = video_set_use_native_backlight,
> .ident = "Dell Inspiron 7520",
> .matches = {
>
next prev parent reply other threads:[~2014-04-08 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 14:44 [PATCH] Favor native backlight interface for ThinkPad Helix Stephen Chandler Paul
2014-04-08 2:49 ` Aaron Lu [this message]
2014-04-08 12:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534363AD.9070401@intel.com \
--to=aaron.lu@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=shawn.t.rutledge@gmail.com \
--cc=thatslyude@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).