From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757199AbaDHPTz (ORCPT ); Tue, 8 Apr 2014 11:19:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36002 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756369AbaDHPTx (ORCPT ); Tue, 8 Apr 2014 11:19:53 -0400 Message-ID: <53441398.2020709@suse.cz> Date: Tue, 08 Apr 2014 17:19:52 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Randy Dunlap CC: Sam Ravnborg , Masahiro Yamada , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH] kbuild: create a build directory automatically for out-of-tree build References: <1396251696-14815-1-git-send-email-yamada.m@jp.panasonic.com> <20140331203615.GA22334@ravnborg.org> <533AFB06.6020207@infradead.org> In-Reply-To: <533AFB06.6020207@infradead.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-04-01 19:44, Randy Dunlap wrote: > On 03/31/2014 01:36 PM, Sam Ravnborg wrote: >> In the past I have rejected such patches - but today I fail to recall why. > > I believe that it was due this kind of patch allowing typos to cause > builds that one does not want to make. > > E.g., if I already have O=OUT1 directory and I mistype O=OUT2, this will cause > a full build (potentially) in OUT2, even if it should do a small rebuild in > OUT1 instead. I thought about this possibility before applying the patch. But if this happens, then a build in the mistyped directory will immediately fail due to lack of .config. Michal