From: Joshua Clayton <stillcompiling@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Mark Brown <broonie@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Adrian Remonda <adrianremonda@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx
Date: Tue, 17 Nov 2015 11:21:12 -0800 [thread overview]
Message-ID: <5345436.HCqatbevmx@jclayton-pc> (raw)
In-Reply-To: <20151117174333.GY31303@sirena.org.uk>
On Tuesday, November 17, 2015 05:43:33 PM Mark Brown wrote:
> On Tue, Nov 17, 2015 at 07:24:22AM -0800, Joshua Clayton wrote:
> > Put input from string into its own function.
>
> Again, why are we doing this? I'm having a hard time seeing what the
> gain is, the amount of code being moved is tiny.
It takes some clutter out of main() whose scope is limited to that little block of code,
and because in the next patch we add another (larger)function to the if/else block.
I don't know if it is valid to say "look at the next commit" for justification, but
That is the reason.
--
~Joshua Clayton
next prev parent reply other threads:[~2015-11-17 19:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 15:24 [PATCH 0/8] spi: Add file i/o to spidev_test Joshua Clayton
2015-11-17 15:24 ` [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer Joshua Clayton
2015-11-17 17:41 ` Mark Brown
2015-11-17 18:58 ` Joshua Clayton
2015-11-17 15:24 ` [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx Joshua Clayton
2015-11-17 17:43 ` Mark Brown
2015-11-17 19:21 ` Joshua Clayton [this message]
2015-11-17 22:52 ` Mark Brown
2015-11-17 15:24 ` [PATCH 3/8] Documentation/spi/spidev_test.c: accept input from a file Joshua Clayton
2015-11-17 18:26 ` Anton Bondarenko
2015-11-17 18:46 ` Mark Brown
2015-11-17 19:28 ` Joshua Clayton
2015-11-17 15:24 ` [PATCH 4/8] Documentation/spi/spidev_test.c: output to " Joshua Clayton
2015-11-17 15:24 ` [PATCH 5/8] Documentation/spi/spidev_test.c: check error Joshua Clayton
2015-11-17 15:24 ` [PATCH 6/8] Documentation/spi/spidev_test.c: fix whitespace Joshua Clayton
2015-11-17 15:24 ` [PATCH 7/8] tools/Makefile: minor whitespace cleanup Joshua Clayton
2015-11-17 18:09 ` Mark Brown
2015-11-17 19:41 ` Joshua Clayton
2015-11-17 15:24 ` [PATCH 8/8] spi: Move spi code from Documentation to tools Joshua Clayton
2015-11-17 18:11 ` Mark Brown
2015-11-17 15:37 ` [PATCH 0/8] spi: Add file i/o to spidev_test Mark Brown
2015-11-17 16:15 ` Joshua Clayton
2015-11-17 16:53 ` Mark Brown
2015-11-18 22:30 ` [PATCH v2 0/6] " Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 1/6] spi: Move spi code from Documentation to tools Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 2/6] spi: spidev_test: transfer_escaped_string function Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 3/6] spi: spidev_test: accept input from a file Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 4/6] spi: spidev_test: output to " Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 5/6] spi: spidev_test: check error Joshua Clayton
2015-11-18 22:30 ` [PATCH v2 6/6] spi: spidev_test: fix whitespace Joshua Clayton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5345436.HCqatbevmx@jclayton-pc \
--to=stillcompiling@gmail.com \
--cc=adrianremonda@gmail.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox