From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] extcon: max14577: Fix probe failure on successful work queue
Date: Thu, 10 Apr 2014 12:50:37 +0900 [thread overview]
Message-ID: <5346150D.5050307@samsung.com> (raw)
In-Reply-To: <1397037369-24995-1-git-send-email-k.kozlowski@samsung.com>
Hi Krzysztof,
On 04/09/2014 06:56 PM, Krzysztof Kozlowski wrote:
> In probe the driver queued delayed work for cable detection and
> returned the result of queue_delayed_work() call. However the return
> value of queue_delayed_work() does not indicate an error and in normal
> condition it returns true which means successful work queue.
> This effectively resulted in probe failure:
> [ 2.088204] max14577-muic: probe of max77836-muic failed with error 1
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: <stable@vger.kernel.org>
> Fixes: 962e56bfcf0b ("extcon: max14577: Add extcon-max14577 driver...")
> ---
> drivers/extcon/extcon-max14577.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Applied this patch.
but, you could check this patch on extcon-next branch
after few days. becuase I have firewall issue of kerner.org.
Thanks,
Chanwoo Choi
prev parent reply other threads:[~2014-04-10 3:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 9:56 [PATCH] extcon: max14577: Fix probe failure on successful work queue Krzysztof Kozlowski
2014-04-10 3:50 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5346150D.5050307@samsung.com \
--to=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox