From: Wolfgang Bauer <wbauer@tmo.at>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Jiri Kosina <jikos@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] HID: input: fix a4tech horizontal wheel custom usage
Date: Thu, 13 Jun 2019 13:48:52 +0200 [thread overview]
Message-ID: <5346893.KeHrH3GHoD@linux-lf90.site> (raw)
In-Reply-To: <CAO-hwJLAiC1o-kZ5epZHtO2GK+zc5x28pYbZH-XsY4yAuBmHWw@mail.gmail.com>
On Tuesday, 11. Juni 2019, 16:42:37 Benjamin Tissoires wrote:
> On Tue, Jun 11, 2019 at 2:13 PM Nicolas Saenz Julienne
>
> <nsaenzjulienne@suse.de> wrote:
> > NOTE: I CC'd Wolfgang as he's the one who can test this.
>
> I'll wait for Wolfram to confirm that the patch works before pushing then.
My name is Wolfgang, not Wolfram... ;-)
But never mind.
I tested the patch meanwhile on top of kernel 5.2.rc4, where the mouse wheel
actually worked.
As the patch didn't apply cleanly (it's obviously based upon
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=abf82e8f7e9af40a49e3d905187c662a43c96c8f , called "HID-
a4tech-fix-horizontal-scrolling.patch" below), I added that patch as well.
My results:
kernel 5.2.rc4 works
kernel 5.2.rc4 + HID-a4tech-fix-horizontal-scrolling.patch is broken
kernel 5.2.rc4 + HID-a4tech-fix-horizontal-scrolling.patch +
HID-input-fix-a4tech-horizontal-wheel-custom-usage.patch (i.e. this patch)
works again
kernel 5.2.rc4 + HID-input-fix-a4tech-horizontal-wheel-custom-usage.patch
works as well.
So AFAICT this patch seems to be fine.
For completeness, this is my mouse as listed by lsusb:
Bus 003 Device 002: ID 09da:000a A4Tech Co., Ltd. Optical Mouse Opto 510D /
OP-620D
Kind Regards,
Wolfgang
next prev parent reply other threads:[~2019-06-13 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 12:13 [PATCH v2] HID: input: fix a4tech horizontal wheel custom usage Nicolas Saenz Julienne
2019-06-11 14:42 ` Benjamin Tissoires
2019-06-13 11:48 ` Wolfgang Bauer [this message]
2019-06-14 13:36 ` Benjamin Tissoires
2019-06-14 14:25 ` Nicolas Saenz Julienne
2019-07-05 10:28 ` Nicolas Saenz Julienne
2019-07-18 15:46 ` Jeremy Cline
2019-06-14 12:00 ` Wolfgang Bauer
2019-08-01 10:56 ` Nicolas Saenz Julienne
2019-08-05 12:38 ` Jiri Kosina
2019-08-25 20:50 ` Heorhi Valakhanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5346893.KeHrH3GHoD@linux-lf90.site \
--to=wbauer@tmo.at \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=wbauer1@a1.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox