From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030386AbaDJSLK (ORCPT ); Thu, 10 Apr 2014 14:11:10 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:38759 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753244AbaDJSLH (ORCPT ); Thu, 10 Apr 2014 14:11:07 -0400 Message-ID: <5346DEB1.4050507@fb.com> Date: Thu, 10 Apr 2014 12:10:57 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Benjamin Herrenschmidt CC: Jan Kara , Linux Kernel Mailing List , Frederic Weisbecker , James Bottomley , Brian J King Subject: Re: [BUG] kernel BUG at /.../block/cfq-iosched.c:3145! References: <1397018647.3671.123.camel@pasglop> <53454CBC.9060905@fb.com> <1397087273.3671.150.camel@pasglop> <1397088144.3671.155.camel@pasglop> <5345F476.2000602@fb.com> <1397093815.3671.156.camel@pasglop> <5346012A.50901@fb.com> <1397100937.3671.160.camel@pasglop> <5346158B.90005@fb.com> <1397112333.3671.179.camel@pasglop> In-Reply-To: <1397112333.3671.179.camel@pasglop> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.57.29] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96,1.0.14,0.0.0000 definitions=2014-04-10_05:2014-04-10,2014-04-10,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 kscore.is_bulkscore=1.24344978758018e-14 kscore.compositescore=0 circleOfTrustscore=5.8201264735473 compositescore=0.307752384302029 urlsuspect_oldscore=0.307752384302029 suspectscore=0 recipient_domain_to_sender_totalscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 recipient_to_sender_totalscore=0 recipient_domain_to_sender_domain_totalscore=2524143 rbsscore=0.307752384302029 spamscore=0 recipient_to_sender_domain_totalscore=16 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1404100284 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2014 12:45 AM, Benjamin Herrenschmidt wrote: > On Wed, 2014-04-09 at 21:52 -0600, Jens Axboe wrote: >> On 2014-04-09 21:35, Benjamin Herrenschmidt wrote: >>> On Wed, 2014-04-09 at 20:25 -0600, Jens Axboe wrote: >>>> On 2014-04-09 19:36, Benjamin Herrenschmidt wrote: >>>>> On Wed, 2014-04-09 at 19:31 -0600, Jens Axboe wrote: >>>>>> OK, I think we're seeing different symptoms of the same bug. Stay >>>>>> tuned, will have something for you to test shortly, I hope. >>>>> >>>>> Ah thanks. I'll defer the bisection then (it's painful on that machine >>>>> for various reasons....) >>>> >>>> Can you try with these two patches applied? >>> >>> Booted to login prompt once ... and twice. Much better ! :-) >> >> Excellent! I was hoping it was the same bug :-) >> I'll amend the commit and add your tested-by. > > A colleague was complaining of yet another oddball block related crash > today on another machine when doing rsync's with upstream (this machine > booted fine but crashed later on, but then it has less CPUs... maybe > that's relevant) and these patches fixed it too. Pull request is now in, jfyi. -- Jens Axboe