linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@linux.intel.com>
To: "Romer, Benjamin M" <Benjamin.Romer@unisys.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	Jet Chen <jet.chen@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP
Date: Thu, 10 Apr 2014 19:28:20 -0700	[thread overview]
Message-ID: <53475344.5090009@linux.intel.com> (raw)
In-Reply-To: <C97001BC43954D438ACB059713BA5CDF92040F0F0A@USEA-EXCH7.na.uis.unisys.com>

On 04/10/2014 06:19 AM, Romer, Benjamin M wrote:
> 
> I'm confused by the intended behavior of KVM.. Is the intention of the
> -cpu switch to fully emulate a particular CPU? If that's the case, the
> Intel documentation says bit 31 should always be 0, so the value
> returned by the cpuid instruction isn't correct. If the intention is to
> present a VM with a specific CPU architecture, the CPU ought to behave
> as described in Intel's virtualization documentation and just vmexit
> instead of faulting with invalid op, IMHO. 
> 
> I've already said the check in the code was insufficient, and I'm trying
> to fix that part now. :)
> 

I'm still confused where KVM comes into the picture.  Are you actually
using KVM (and thus talking about nested virtualization) or are you
using Qemu in JIT mode and running another hypervisor underneath?

The hypervisor bit is a complete red herring.  If the guest CPU is
running in VT-x mode, then VMCALL should VMEXIT inside the guest
(invoking the guest root VT-x), but the fact still remains that you
should never, ever, invoke VMCALL unless you know what hypervisor you
have underneath.

	-hpa


  reply	other threads:[~2014-04-11  2:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 11:17 [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP Fengguang Wu
2014-04-07 14:04 ` Ken Cox
2014-04-07 14:09 ` Greg Kroah-Hartman
2014-04-07 14:24   ` Ken Cox
2014-04-07 19:23     ` Greg Kroah-Hartman
2014-04-07 19:46       ` Greg Kroah-Hartman
     [not found] ` <C97001BC43954D438ACB059713BA5CDF92040F0F00@USEA-EXCH7.na.uis.unisys.com>
2014-04-08  2:53   ` Fengguang Wu
2014-04-08 15:39     ` Romer, Benjamin M
     [not found]   ` <53444220.50009@intel.com>
     [not found]     ` <C97001BC43954D438ACB059713BA5CDF92040F0F06@USEA-EXCH7.na.uis.unisys.com>
     [not found]       ` <53458A3A.1050608@intel.com>
2014-04-09 23:01         ` Fengguang Wu
2014-04-09 23:10           ` H. Peter Anvin
2014-04-10 13:19             ` Romer, Benjamin M
2014-04-11  2:28               ` H. Peter Anvin [this message]
2014-04-11 13:51                 ` Romer, Benjamin M
2014-04-11 16:33                   ` H. Peter Anvin
2014-04-11 17:35                     ` Jet Chen
2014-04-11 17:40                       ` H. Peter Anvin
2014-04-11 17:51                         ` Romer, Benjamin M
2014-04-30 10:02                         ` Paolo Bonzini
2014-04-11 17:49                       ` Romer, Benjamin M
2014-04-13 11:51                       ` Borislav Petkov
2014-04-13 12:20                         ` Jet Chen
2014-04-09 23:10           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53475344.5090009@linux.intel.com \
    --to=hpa@linux.intel.com \
    --cc=Benjamin.Romer@unisys.com \
    --cc=bp@alien8.de \
    --cc=fengguang.wu@intel.com \
    --cc=jet.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).