* [PATCH] staging: wlan-ng: fix bad symbol declaration
@ 2014-04-11 13:00 Neil Armstrong
2014-04-11 13:41 ` Josh Triplett
0 siblings, 1 reply; 2+ messages in thread
From: Neil Armstrong @ 2014-04-11 13:00 UTC (permalink / raw)
To: Greg Kroah-Hartman, Josh Triplett, Himangi Saraogi, Tugce Sirin
Cc: devel, linux-kernel
With sparse, the following error appears :
CHECK drivers/staging/wlan-ng/p80211netdev.c
drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol 'prism2_connect_result' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol 'prism2_disconnected' was not declared. Should it be static?
drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol 'prism2_roamed' was not declared. Should it be static?
Move functions declaration to coherent internal header file.
Signed-off-by: Neil 'Superna' Armstrong <superna9999@gmail.com>
---
drivers/staging/wlan-ng/prism2mgmt.h | 5 +++++
drivers/staging/wlan-ng/prism2sta.c | 4 ----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
index 190d390..b62fdcb 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.h
+++ b/drivers/staging/wlan-ng/prism2mgmt.h
@@ -109,4 +109,9 @@ void prism2sta_processing_defer(struct work_struct *data);
void prism2sta_commsqual_defer(struct work_struct *data);
void prism2sta_commsqual_timer(unsigned long data);
+/* Interface callback functions, passing data back up to the cfg80211 layer */
+void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
+void prism2_disconnected(wlandevice_t *wlandev);
+void prism2_roamed(wlandevice_t *wlandev);
+
#endif
diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
index f9ccf23..3fd4538 100644
--- a/drivers/staging/wlan-ng/prism2sta.c
+++ b/drivers/staging/wlan-ng/prism2sta.c
@@ -120,10 +120,6 @@ MODULE_PARM_DESC(prism2_reset_settletime, "reset settle time in ms");
MODULE_LICENSE("Dual MPL/GPL");
-void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
-void prism2_disconnected(wlandevice_t *wlandev);
-void prism2_roamed(wlandevice_t *wlandev);
-
static int prism2sta_open(wlandevice_t *wlandev);
static int prism2sta_close(wlandevice_t *wlandev);
static void prism2sta_reset(wlandevice_t *wlandev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: wlan-ng: fix bad symbol declaration
2014-04-11 13:00 [PATCH] staging: wlan-ng: fix bad symbol declaration Neil Armstrong
@ 2014-04-11 13:41 ` Josh Triplett
0 siblings, 0 replies; 2+ messages in thread
From: Josh Triplett @ 2014-04-11 13:41 UTC (permalink / raw)
To: Neil Armstrong
Cc: Greg Kroah-Hartman, Himangi Saraogi, Tugce Sirin, devel,
linux-kernel
On Fri, Apr 11, 2014 at 03:00:49PM +0200, Neil Armstrong wrote:
> With sparse, the following error appears :
> CHECK drivers/staging/wlan-ng/p80211netdev.c
> drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol 'prism2_connect_result' was not declared. Should it be static?
> drivers/staging/wlan-ng/cfg80211.c:719:6: warning: symbol 'prism2_disconnected' was not declared. Should it be static?
> drivers/staging/wlan-ng/cfg80211.c:725:6: warning: symbol 'prism2_roamed' was not declared. Should it be static?
>
> Move functions declaration to coherent internal header file.
>
> Signed-off-by: Neil 'Superna' Armstrong <superna9999@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/staging/wlan-ng/prism2mgmt.h | 5 +++++
> drivers/staging/wlan-ng/prism2sta.c | 4 ----
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
> index 190d390..b62fdcb 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -109,4 +109,9 @@ void prism2sta_processing_defer(struct work_struct *data);
> void prism2sta_commsqual_defer(struct work_struct *data);
> void prism2sta_commsqual_timer(unsigned long data);
>
> +/* Interface callback functions, passing data back up to the cfg80211 layer */
> +void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
> +void prism2_disconnected(wlandevice_t *wlandev);
> +void prism2_roamed(wlandevice_t *wlandev);
> +
> #endif
> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
> index f9ccf23..3fd4538 100644
> --- a/drivers/staging/wlan-ng/prism2sta.c
> +++ b/drivers/staging/wlan-ng/prism2sta.c
> @@ -120,10 +120,6 @@ MODULE_PARM_DESC(prism2_reset_settletime, "reset settle time in ms");
>
> MODULE_LICENSE("Dual MPL/GPL");
>
> -void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
> -void prism2_disconnected(wlandevice_t *wlandev);
> -void prism2_roamed(wlandevice_t *wlandev);
> -
> static int prism2sta_open(wlandevice_t *wlandev);
> static int prism2sta_close(wlandevice_t *wlandev);
> static void prism2sta_reset(wlandevice_t *wlandev);
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-11 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-11 13:00 [PATCH] staging: wlan-ng: fix bad symbol declaration Neil Armstrong
2014-04-11 13:41 ` Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox