public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pascal COMBES <pascom@orange.fr>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
	Jarod Wilson <jarod@wilsonet.com>,
	Jingoo Han <jg1.han@samsung.com>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	linux-kernel@vger.kernel.org, Naren Sankar <nsankar@broadcom.com>,
	Monam Agarwal <monamagarwal123@gmail.com>,
	Scott Davilla <davilla@4pi.com>,
	Amarjargal Gundjalam <amarjargal16@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Robert Foss <dev@robertfoss.se>
Subject: [PATCH v2 3/3] Fix coding style problem (sizeof with type) in drivers/staging/crystalhd/crystalhd_lnx.c
Date: Sun, 13 Apr 2014 21:13:29 +0200	[thread overview]
Message-ID: <534AE1D9.1000005@orange.fr> (raw)
In-Reply-To: <20140413154859.GA18189@kroah.com>

From: Pascal COMBES <pascom@orange.fr>

Replace sizeof(type) by sizeof(variable) in
drivers/staging/crystalhd/crystalhd_lnx.c.

Signed-off-by: Pascal COMBES <pascom@orange.fr>
---
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c
b/drivers/staging/crystalhd/crystalhd_lnx.c
index 15e8f02..7b14b28 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging/crystalhd/crystalhd_lnx.c
@@ -399,8 +399,7 @@ static int chd_dec_init_chdev(struct crystalhd_adp *adp)

 	/* Allocate general purpose ioctl pool. */
 	for (i = 0; i < CHD_IODATA_POOL_SZ; i++) {
-		temp = kzalloc(sizeof(struct crystalhd_ioctl_data),
-			       GFP_KERNEL);
+		temp = kzalloc(sizeof(*temp), GFP_KERNEL);
 		if (!temp) {
 			BCMLOG_ERR("ioctl data pool kzalloc failed\n");
 			rc = -ENOMEM;
@@ -555,7 +554,7 @@ static int chd_dec_pci_probe(struct pci_dev *pdev,
 	       pdev->vendor, pdev->device, pdev->subsystem_vendor,
 	       pdev->subsystem_device);

-	pinfo = kzalloc(sizeof(struct crystalhd_adp), GFP_KERNEL);
+	pinfo = kzalloc(sizeof(*pinfo), GFP_KERNEL);
 	if (!pinfo) {
 		BCMLOG_ERR("Failed to allocate memory\n");
 		return -ENOMEM;


  parent reply	other threads:[~2014-04-13 19:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-13 15:35 [PATCH] Fix coding style in drivers/staging/crystalhd/crystalhd_lnx.c Pascal COMBES
2014-04-13 15:48 ` Greg Kroah-Hartman
2014-04-13 19:09   ` [PATCH v2 1/3] Fix alignement problems " Pascal COMBES
2014-04-13 21:02     ` Dan Carpenter
2014-04-13 21:26       ` Paul Bolle
2014-04-13 22:07         ` Dan Carpenter
2014-04-13 22:13           ` Paul Bolle
2014-04-13 22:45             ` Dan Carpenter
2014-04-13 19:13   ` [PATCH v2 2/3] Fix coding style problem (cast with space) " Pascal COMBES
2014-04-13 21:36     ` Paul Bolle
2014-04-14 16:37       ` Pascal COMBES
2014-04-15  0:44         ` Jingoo Han
2014-04-13 19:13   ` Pascal COMBES [this message]
2014-04-15 19:21   ` [PATCH v3 1/3] Staging: crystalhd: Fix alignement in crystalhd_lnx.c Pascal COMBES
2014-04-15 19:32     ` Dan Carpenter
2014-04-15 19:21   ` [PATCH v3 2/3] Staging: crystalhd: Removed cast " Pascal COMBES
2014-04-15 19:21   ` [PATCH v3 3/3] Staging: crystalhd: Improve kzalloc calls " Pascal COMBES

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534AE1D9.1000005@orange.fr \
    --to=pascom@orange.fr \
    --cc=amarjargal16@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davilla@4pi.com \
    --cc=dev@robertfoss.se \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jarod@wilsonet.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monamagarwal123@gmail.com \
    --cc=nsankar@broadcom.com \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox