From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754738AbaDNMp2 (ORCPT ); Mon, 14 Apr 2014 08:45:28 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:60573 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbaDNMp1 (ORCPT ); Mon, 14 Apr 2014 08:45:27 -0400 Message-ID: <534BD77E.4020405@huawei.com> Date: Mon, 14 Apr 2014 20:41:34 +0800 From: Liu hua User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Will Deacon CC: "linux@arm.linux.org.uk" , "horms@verge.net.au" , "linux-arm-kernel@lists.infradead.org" , "kexec@lists.infradead.org" , Stephen Warren , "Vijaya Kumar K" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/3] ARM : kdump : add arch_crash_save_vmcoreinfo References: <1395907240-13308-1-git-send-email-sdu.liu@huawei.com> <1395907240-13308-3-git-send-email-sdu.liu@huawei.com> <20140414113718.GD3530@arm.com> In-Reply-To: <20140414113718.GD3530@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.111.58.238] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2014/4/14 19:37, Will Deacon 写道: > On Thu, Mar 27, 2014 at 08:00:39AM +0000, Liu Hua wrote: >> For vmcore generated by LPAE enabled kernel, user space >> utility such as crash needs additional infomation to >> parse. >> >> So this patch add arch_crash_save_vmcoreinfo as what PAE enabled >> i386 linux does. > > Looks sensible to me: > > Reviewed-by: Will Deacon > > Will Hi Will, Thanks to you reply. How about the first one of the patch series named "[PATCH 1/3] ARM : kdump : Add LPAE support". Now the ARM linux will simply return error when parse an LPAE enabled kernel, becausethe commit 4b3bf7ae provide zero vmcore_elf64_check_arch(). So if we want parse LPAE enabled kernel, we need that one. Thanks, Liu Hua > >> Signed-off-by: Liu Hua >> To: Russell King >> Cc: Stephen Warren >> Cc: Will Deacon >> Cc: Vijaya Kumar K >> Cc: >> Cc: >> Cc: >> --- >> arch/arm/kernel/machine_kexec.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c >> index f0d180d..8cf0996 100644 >> --- a/arch/arm/kernel/machine_kexec.c >> +++ b/arch/arm/kernel/machine_kexec.c >> @@ -184,3 +184,10 @@ void machine_kexec(struct kimage *image) >> >> soft_restart(reboot_entry_phys); >> } >> + >> +void arch_crash_save_vmcoreinfo(void) >> +{ >> +#ifdef CONFIG_ARM_LPAE >> + VMCOREINFO_CONFIG(ARM_LPAE); >> +#endif >> +} >> -- >> 1.9.0 >> >> > > . >