From: "Li, ZhenHua" <zhen-hual@hp.com>
To: David Miller <davem@davemloft.net>
Cc: kas@fi.muni.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] driver/net: remove unused code in cosa module
Date: Tue, 15 Apr 2014 09:44:31 +0800 [thread overview]
Message-ID: <534C8EFF.1030804@hp.com> (raw)
In-Reply-To: <20140414.133100.2108506432746999980.davem@davemloft.net>
Thanks for your correction. I will send again with proper reason.
On 04/15/2014 01:31 AM, David Miller wrote:
> From: "Li, Zhen-Hua" <zhen-hual@hp.com>
> Date: Mon, 14 Apr 2014 18:08:36 +0800
>
>> For the cosa module, CONFIG_COSA can only be checked as 'm',
>> and cosa module can only be compiled as a module.
> That's not true, it's "tristate" in drivers/net/wan/Kconfig so it
> could be set to 'y' too.
>
> But there is another reason to make this change, because for such
> large timeout values only msleep() makes sense, udelay() could
> overflow it's internal precision.
>
> Please resubmit this with the proper reasoning and commit message.
prev parent reply other threads:[~2014-04-15 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 10:08 [PATCH 1/1] driver/net: remove unused code in cosa module Li, Zhen-Hua
2014-04-14 17:31 ` David Miller
2014-04-15 1:44 ` Li, ZhenHua [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534C8EFF.1030804@hp.com \
--to=zhen-hual@hp.com \
--cc=davem@davemloft.net \
--cc=kas@fi.muni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox