Re: [PATCH 2/4] workqueues: Account unbound workqueue in a seperate list

Tejun Heo
2014-04-03T15:01:51Z

Hello,

On Thu, Apr 03, 2014 at 04:48:28PM +0200, Frederic Weisbecker wrote:
> > Wouldn't the right thing to do would be factoring out
> > apply_workqueue_attrs_locked()? It's cleaner to block out addition of
> > new workqueues while the masks are being updated anyway.
>
> I'm not quite sure I get what you suggest. Do you mean have
> apply_workqueue_attrs_locked() calling apply_workqueue_attrs() under
> the lock on this patch?

Not sure it still matters but I was suggesting that creating
apply_workqueue_attrs_locked() which requires the caller to handle
locking and making apply_workqueue_attrs() a wrapper which grabs and
releases lock around it, and using the former in locked iteration
would work. lol has this explanation made it any clearer or is it
even worse now? :)

Thanks.

--
tejun