From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752772AbaDPQo6 (ORCPT ); Wed, 16 Apr 2014 12:44:58 -0400 Received: from mail-pb0-f54.google.com ([209.85.160.54]:41672 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbaDPQo4 (ORCPT ); Wed, 16 Apr 2014 12:44:56 -0400 Message-ID: <534EB38F.7050801@kernel.dk> Date: Wed, 16 Apr 2014 10:45:03 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Christoph Hellwig CC: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 2/8] blk-mq: bidi support References: <1397634299-7466-1-git-send-email-hch@lst.de> <1397634299-7466-3-git-send-email-hch@lst.de> <534EB2BA.7020705@kernel.dk> <20140416164406.GA19850@lst.de> In-Reply-To: <20140416164406.GA19850@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/16/2014 10:44 AM, Christoph Hellwig wrote: > On Wed, Apr 16, 2014 at 10:41:30AM -0600, Jens Axboe wrote: >>> - if (!q->request_fn) >>> + if (!q->request_fn && !q->mq_ops) >>> return 0; >>> >>> bcd = &q->bsg_dev; >> >> This looks misplaced. But I dropped the one I generated last week, I'll >> queue it up separately in the drivers branch. > > Could be argued that it should be a separate patch, but the check should > work fine. There's nothing wrong with the check, it's identical to one I sent out last week. But it's not part of the bidi enable patch, it's a separate bug fix for bsg. -- Jens Axboe