Re: [PATCH V5.1] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers

[Stephen Warren <swarren@wwwdotorg.org>]

On 04/15/2014 08:08 PM, Yoshihiro YUNOMAE wrote:
> Hi Stephen,
> 
> Thank you for your review.
> 
> (2014/04/16 2:39), Stephen Warren wrote:
>> On 04/15/2014 02:06 AM, Yoshihiro YUNOMAE wrote:
>>> /* I found a bug in V5, so I resend this as V5.1. Please do not
>>> review V5. */
>>>
>>> Add tunable RX interrupt trigger I/F of FIFO buffers.
>>> Serial devices are used as not only message communication devices but
>>> control
>>> or sending communication devices. For the latter uses, normally small
>>> data
>>> will be exchanged, so user applications want to receive data unit as
>>> soon as
>>> possible for real-time tendency. If we have a sensor which sends a 1
>>> byte data
>>> each time and must control a device based on the sensor feedback, the RX
>>> interrupt should be triggered for each data.
>>>
>>> According to HW specification of serial UART devices, RX interrupt
>>> trigger
>>> can be changed, but the trigger is hard-coded. For example, RX
>>> interrupt trigger
>>> in 16550A can be set to 1, 4, 8, or 14 bytes for HW, but current
>>> driver sets
>>> the trigger to only 8bytes.

>>> diff --git a/drivers/tty/serial/8250/8250_core.c
>>> b/drivers/tty/serial/8250/8250_core.c
>>
>>> @@ -2275,10 +2276,9 @@ serial8250_do_set_termios(struct uart_port
>>> *port, struct ktermios *termios,
>>
>>>       if (up->capabilities & UART_CAP_FIFO && port->fifosize > 1) {
>>> -        fcr = uart_config[port->type].fcr;
>>> -        if ((baud < 2400 && !up->dma) || fifo_bug) {
>>> -            fcr &= ~UART_FCR_TRIGGER_MASK;
>>> -            fcr |= UART_FCR_TRIGGER_1;
>>> +        /* NOTE: If fifo_bug is not set, a uaser can set RX_trigger. */
>>> +        if ((baud < 2400 && !up->dma &&
>>> +            (up->fcr == uart_config[port->type].fcr)) ||
>>> up->fifo_bug) {
>>> +            up->fcr &= ~UART_FCR_TRIGGER_MASK;
>>> +            up->fcr |= UART_FCR_TRIGGER_1;
>>>           }
>>>       }
>>
>> Does the "(up->fcr == uart_config[port->type].fcr)" term prevent the
>> user from changing the trigger level multiple times? Perhaps this is
>> intended?
> 
> No, this means that if a user changed FCR value before setting termios,
> use the changed value because the user think changed value is always
> set. But, I thought this is not straightforward and it cannot help
> when the user want to use default FCR value.
> Could I add FCR changed flag(user_changed_fcr) in uart_8250_port
> structure and check the flag here?
> Or shouldn't the driver check the user changing?

Oh, I wasn't aware that the user could change FCR directly. To be
honest, I'm not sure of the best way to resolve that kind of conflict...