Re: [PATCH] perf tools: Fix pmu object compilation error

[David Ahern <dsahern@gmail.com>]

On 4/16/14, 1:00 PM, Jiri Olsa wrote:
> After applying some patches got another shadowing error:
>
>    CC       util/pmu.o
> util/pmu.c: In function ‘pmu_alias_terms’:
> util/pmu.c:287:35: error: declaration of ‘clone’ shadows a global declaration [-Werror=shadow]
>
> Renaming clone to cloned.
>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> ---
>   tools/perf/util/pmu.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 00a7dcb..7a811eb 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -284,17 +284,17 @@ static int pmu_aliases(const char *name, struct list_head *head)
>   static int pmu_alias_terms(struct perf_pmu_alias *alias,
>   			   struct list_head *terms)
>   {
> -	struct parse_events_term *term, *clone;
> +	struct parse_events_term *term, *cloned;
>   	LIST_HEAD(list);
>   	int ret;
>
>   	list_for_each_entry(term, &alias->terms, list) {
> -		ret = parse_events_term__clone(&clone, term);
> +		ret = parse_events_term__clone(&cloned, term);
>   		if (ret) {
>   			parse_events__free_terms(&list);
>   			return ret;
>   		}
> -		list_add_tail(&clone->list, &list);
> +		list_add_tail(&cloned->list, &list);
>   	}
>   	list_splice(&list, terms);
>   	return 0;
>

Acked-by: David Ahern <dsahern@gmail.com>