* [PATCH] staging: android: binder.c: avoid sparse checker warning: cast removes address space of expression
@ 2014-04-16 20:42 Yves Deweerdt
2014-04-16 23:58 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Yves Deweerdt @ 2014-04-16 20:42 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Arve Hjønnevåg,
Serban Constantinescu, Bojan Prtvar, John Stultz, Masanari Iida,
devel
__user should be kept when casting to struct binder_version *
Signed-off-by: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
---
drivers/staging/android/binder.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index cfe4bc8..0f74e43 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -2683,16 +2683,21 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
binder_free_thread(proc, thread);
thread = NULL;
break;
- case BINDER_VERSION:
+ case BINDER_VERSION: {
+ struct binder_version __user *bv =
+ (struct binder_version __user *)ubuf;
+
if (size != sizeof(struct binder_version)) {
ret = -EINVAL;
goto err;
}
- if (put_user(BINDER_CURRENT_PROTOCOL_VERSION, &((struct binder_version *)ubuf)->protocol_version)) {
+ if (put_user(BINDER_CURRENT_PROTOCOL_VERSION,
+ &(bv->protocol_version))) {
ret = -EINVAL;
goto err;
}
break;
+ }
default:
ret = -EINVAL;
goto err;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: android: binder.c: avoid sparse checker warning: cast removes address space of expression
2014-04-16 20:42 [PATCH] staging: android: binder.c: avoid sparse checker warning: cast removes address space of expression Yves Deweerdt
@ 2014-04-16 23:58 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-04-16 23:58 UTC (permalink / raw)
To: Yves Deweerdt
Cc: linux-kernel, devel, Greg Kroah-Hartman, Serban Constantinescu,
Arve Hjønnevåg, John Stultz, Bojan Prtvar,
mathieu.maret
On Wed, Apr 16, 2014 at 10:42:17PM +0200, Yves Deweerdt wrote:
>
> __user should be kept when casting to struct binder_version *
>
>
Mathieu sent this one earlier.
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-April/048614.html
His is perfect, except that he missed the space in the ": {", but it's
still ok.
regards,
dan carpenter
> Signed-off-by: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
> ---
> drivers/staging/android/binder.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index cfe4bc8..0f74e43 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -2683,16 +2683,21 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> binder_free_thread(proc, thread);
> thread = NULL;
> break;
> - case BINDER_VERSION:
> + case BINDER_VERSION: {
> + struct binder_version __user *bv =
> + (struct binder_version __user *)ubuf;
> +
> if (size != sizeof(struct binder_version)) {
> ret = -EINVAL;
> goto err;
> }
> - if (put_user(BINDER_CURRENT_PROTOCOL_VERSION, &((struct binder_version *)ubuf)->protocol_version)) {
> + if (put_user(BINDER_CURRENT_PROTOCOL_VERSION,
> + &(bv->protocol_version))) {
> ret = -EINVAL;
> goto err;
> }
> break;
> + }
> default:
> ret = -EINVAL;
> goto err;
> --
> 1.8.3.2
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-16 23:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-16 20:42 [PATCH] staging: android: binder.c: avoid sparse checker warning: cast removes address space of expression Yves Deweerdt
2014-04-16 23:58 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).