public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ipmi: fix seq number of bt msg in debug message
@ 2014-04-17  9:25 Xie XiuQi
  0 siblings, 0 replies; only message in thread
From: Xie XiuQi @ 2014-04-17  9:25 UTC (permalink / raw)
  To: Corey Minyard; +Cc: openipmi-developer, linux-kernel@vger.kernel.org

The seq number of HOST2BMC message in debug message
is not the real seq number but the next seq number;
we could directly just use bt->write_data[2].

pre:
[99477.760284] BT: +++++++++++++++++ New command
[99477.760286] BT: NetFn/LUN CMD [1 data]: 28 10 0c
[99477.760296] BT: write 5 bytes seq=0x88 04 28 87 10 0c
                                 ^^^^^^^^       ^^
[99477.772078] BT: got 8 bytes seq=0x87 07 2c 87 10 00 f8 07 00
[99477.772091] BT: result 6 bytes: 2c 10 00 f8 07 00

post:
[99477.760284] BT: +++++++++++++++++ New command
[99477.760286] BT: NetFn/LUN CMD [1 data]: 28 10 0c
[99477.760296] BT: write 5 bytes seq=0x87 04 28 87 10 0c
                                 ^^^^^^^^       ^^
[99477.772078] BT: got 8 bytes seq=0x87 07 2c 87 10 00 f8 07 00
[99477.772091] BT: result 6 bytes: 2c 10 00 f8 07 00

Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
---
 drivers/char/ipmi/ipmi_bt_sm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c
index f5e4cd7..1a2056f 100644
--- a/drivers/char/ipmi/ipmi_bt_sm.c
+++ b/drivers/char/ipmi/ipmi_bt_sm.c
@@ -341,7 +341,7 @@ static inline void write_all_bytes(struct si_sm_data *bt)

 	if (bt_debug & BT_DEBUG_MSG) {
 		printk(KERN_WARNING "BT: write %d bytes seq=0x%02X",
-			bt->write_count, bt->seq);
+			bt->write_count, bt->write_data[2]);
 		for (i = 0; i < bt->write_count; i++)
 			printk(" %02x", bt->write_data[i]);
 		printk("\n");
-- 
1.6.0.2



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-17  9:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-17  9:25 [PATCH] ipmi: fix seq number of bt msg in debug message Xie XiuQi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox