From: "Jörg-Volker Peetz" <jvpeetz@web.de>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()
Date: Thu, 17 Apr 2014 21:03:22 +0200 [thread overview]
Message-ID: <5350257A.30107@web.de> (raw)
In-Reply-To: <1397749778-14485-4-git-send-email-tom.leiming@gmail.com>
Ming Lei wrote, on 04/17/2014 17:49:
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> block/blk-mq.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index baff2d0..1eff3d9 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1130,12 +1130,7 @@ static void blk_mq_free_rq_map(struct blk_mq_tag_set *set,
>
> static size_t order_to_size(unsigned int order)
> {
> - size_t ret = PAGE_SIZE;
> -
> - while (order--)
> - ret *= 2;
> -
> - return ret;
> + return (1 << order) * PAGE_SIZE;
Shouldn't this be
return ((size_t)1 << order) * PAGE_SIZE;
?
> }
>
> static struct blk_mq_tags *blk_mq_init_rq_map(struct blk_mq_tag_set *set,
>
Regards,
jvp.
next prev parent reply other threads:[~2014-04-17 19:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 15:49 [PATCH next 0/4] blk-mq: misc changes Ming Lei
2014-04-17 15:49 ` [PATCH next 1/4] blk-mq: free hctx->ctx_map when init failed Ming Lei
2014-04-18 14:21 ` Christoph Hellwig
2014-04-17 15:49 ` [PATCH next 2/4] blk-mq: fix allocation of set->tags Ming Lei
2014-04-18 14:22 ` Christoph Hellwig
2014-04-17 15:49 ` [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size() Ming Lei
2014-04-17 19:03 ` Jörg-Volker Peetz [this message]
2014-04-17 19:13 ` Max Filippov
2014-04-18 15:47 ` Ming Lei
2014-04-18 19:23 ` Jörg-Volker Peetz
2014-04-19 3:17 ` Ming Lei
2014-04-19 5:05 ` Jens Axboe
2014-04-17 15:49 ` [PATCH next 4/4] blk-mq: initialize req->q in allocation Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5350257A.30107@web.de \
--to=jvpeetz@web.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).